Paraview hip variant

[mathstuf]

No description provided.

[mathstuf]

I've tested this on crusher (I used a different way to get Kokkos_CXX_COMPILER, but am testing this diff…if spack would actually get to the build bit).

[vicentebolea]

I've tested this on crusher (I used a different way to get Kokkos_CXX_COMPILER, but am testing this diff…if spack would actually get to the build bit).

Thanks! I will try to replicate this in other HIP enable machines

[vicentebolea]

We need to enable use_vtkm when +rocm

[kwryankrattiger]

We need to enable use_vtkm when +rocm

Really, it needs to conflict with use_vtkm=off since default and on should both be about to handle this correctly.

[mathstuf]

Now conflicts with no-vtkm.

[vicentebolea]

@mathstuf

I was able to build this PR with the following changes:

diff --git a/var/spack/repos/builtin/packages/paraview/package.py b/var/spack/repos/builtin/packages/paraview/package.py
index 0a2195260d..852960fcd7 100644
--- a/var/spack/repos/builtin/packages/paraview/package.py
+++ b/var/spack/repos/builtin/packages/paraview/package.py
@@ -204,7 +204,7 @@ class Paraview(CMakePackage, CudaPackage, ROCmPackage):
     depends_on("llvm-amdgpu", when="+rocm")
     for target in ROCmPackage.amdgpu_targets:
         depends_on(
-            "kokkos amdgpu_target={0}".format(target),
+            "kokkos +rocm amdgpu_target={0}".format(target),
             when="+rocm amdgpu_target={0}".format(target),
         )
 
@@ -591,7 +591,7 @@ def nvariant_bool(feature):
             if "+rocm" in spec:
                 cmake_args.append(
                     "-DKokkos_CXX_COMPILER=%s"
-                    % join_path(spec["llvm-amdgpu"].prefix.bin, "clang++")
+                    % join_path(spec["hip"].prefix.bin, "amdclang++")
                 )
 
         if "+catalyst" in spec:

I also had to rebase to the latest "Develop" as in the current stage certain dependencies would not build.

[kwryankrattiger]

This feature is now merged in #34790