Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mel: new package #34514

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

cristiano-campos
Copy link

Mel is a MPI implementation of Half-approximate Graph Matching.

@hyviquel

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed branch exists but have a couple of suggestions with the most important being to use the real branch name as the name of the version.


maintainers = ["Cgbrl28"]

version("develop", branch="master")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a user perspective (and a general rule), the version name should match the branch.

return targets

def install(self, spec, prefix):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest dropping this blank line.

@tldahlgren tldahlgren self-assigned this Dec 16, 2022
@alecbcs alecbcs changed the title Mel package creation mel: new package May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants