-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mel: new package #34514
base: develop
Are you sure you want to change the base?
mel: new package #34514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed branch exists but have a couple of suggestions with the most important being to use the real branch name as the name of the version.
|
||
maintainers = ["Cgbrl28"] | ||
|
||
version("develop", branch="master") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a user perspective (and a general rule), the version name should match the branch.
return targets | ||
|
||
def install(self, spec, prefix): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest dropping this blank line.
Mel is a MPI implementation of Half-approximate Graph Matching.
@hyviquel