codespell: config, workflow and some typo fixes #36687
Conversation
spackbot-app
bot
added
core
|
Rebased and conflicts resolved (file removed). |
spackbot-app
bot
added
documentation
var/spack/repos/builtin/packages/libsigsegv/patch.new_config_guess
Outdated
Show resolved
Hide resolved
…tions Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
ok, should be good now -- ignored |
|
I would push for the new workflow be an extra step inside of the existing style checks rather than its own standalone CI. |
Suggestion: add to https://github.com/spack/spack/blob/develop/.github/workflows/valid-style.yml after |
|
I kind of wonder if typo checking is more useful as a warning on release branches than as an error on every commit. I'm still concerned about false positives, but I guess we would have to run it on the entire repo to see how many of those there are. |
|
FWIW, we often have codespell even in pre-commit configuration so no typos even get committed. IMHO the sooner they are defected and fixed the better. Decide where to plug the action and I will do or feel free to push such a commit |
Excluded .py files entirely for this initial pass. Someone can remove skipping them and improve there as well