Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update melissa build #37609

Merged
merged 18 commits into from May 26, 2023
Merged

Conversation

mschouler
Copy link
Contributor

From the documentation:

Melissa is a file avoiding, fault tolerant and elastic framework, to run large scale sensitivity analysis and large scale deep surrogate training on supercomputers.

@spackbot-app
Copy link

spackbot-app bot commented May 11, 2023

@raffino @robcaulk can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • melissa-api
  • py-melissa

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the version branches. Asking for a few minor tweaks wrt maintainers and unneeded comments.

var/spack/repos/builtin/packages/melissa-api/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/melissa-api/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-melissa/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-melissa/package.py Outdated Show resolved Hide resolved
@tldahlgren
Copy link
Contributor

@robcaulk @raffino Please confirm you are willing to be maintainers for this package. See https://spack.readthedocs.io/en/latest/packaging_guide.html#maintainers for more information on the role.

@tldahlgren
Copy link
Contributor

Adding @adamjstewart to the PR since the update includes adding a python package (py-melissa).

@mschouler
Copy link
Contributor Author

Confirmed the version branches. Asking for a few minor tweaks wrt maintainers and unneeded comments.

Thank you for your quick review, all requested changes were implemented.

Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments are only suggestions. It sounds like this package is still relatively new and the dependency management system is a WIP, so I'll let you use your best judgement and decide what the dependencies really are. Let me know if you want to leave things as is and I can merge when you're ready.

@mschouler
Copy link
Contributor Author

Remaining comments are only suggestions. It sounds like this package is still relatively new and the dependency management system is a WIP, so I'll let you use your best judgement and decide what the dependencies really are. Let me know if you want to leave things as is and I can merge when you're ready.

Thank you very much for your help and time. Indeed, the way we manage our python dependencies is a bit messy but building a Spack package for Melissa helped us make things cleaner. It should be good to go now.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-confirmed home page and version branches/sha256. Mainly clearing my Request changes as I'll still defer to @adamjstewart for the merge.

@adamjstewart adamjstewart merged commit cd17537 into spack:develop May 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants