New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update melissa build #37609
Update melissa build #37609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the version branches. Asking for a few minor tweaks wrt maintainers and unneeded comments.
@robcaulk @raffino Please confirm you are willing to be maintainers for this package. See https://spack.readthedocs.io/en/latest/packaging_guide.html#maintainers for more information on the role. |
Adding @adamjstewart to the PR since the update includes adding a python package ( |
Thank you for your quick review, all requested changes were implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments are only suggestions. It sounds like this package is still relatively new and the dependency management system is a WIP, so I'll let you use your best judgement and decide what the dependencies really are. Let me know if you want to leave things as is and I can merge when you're ready.
Thank you very much for your help and time. Indeed, the way we manage our python dependencies is a bit messy but building a Spack package for Melissa helped us make things cleaner. It should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-confirmed home page and version branches/sha256. Mainly clearing my Request changes as I'll still defer to @adamjstewart for the merge.
From the documentation: