Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SU2: Update new versions and many variants #37767

Merged
merged 5 commits into from Jun 13, 2023
Merged

SU2: Update new versions and many variants #37767

merged 5 commits into from Jun 13, 2023

Conversation

kjrstory
Copy link
Contributor

@kjrstory kjrstory commented May 18, 2023 •
edited

  • Add new versions(7.4.0, 7.5.0, 7.5.1)

  • Add variants and its dependency.

    • MPI(depends on mpi)
    • OpenMP
    • tecio
    • cgns
    • autodiff
    • directdiff
    • pywrapper (depends on swig,py-mpi4py)
    • mkl(depends on intel-oneapi-mkl)
    • openblas(depends on openblas)
    • mpp(mutation++)
    • mixedprec

    I have tested using %gcc@9.5.0 ubuntu20 cascadelake

@kjrstory kjrstory marked this pull request as draft May 18, 2023 16:44
@spackbot-app spackbot-app bot added the patch label May 18, 2023
@kjrstory kjrstory marked this pull request as ready for review May 18, 2023 18:52
@kjrstory kjrstory mentioned this pull request May 18, 2023
Closed
eli-schwartz
eli-schwartz reviewed May 18, 2023
View reviewed changes
var/spack/repos/builtin/packages/su2/package.py
depends_on("openblas", when="+openblas ~mkl")
depends_on("cmake", when="+mpp")

patch("meson_version.patch", when="@7.4.0:7.5.1")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks reasonable and since the depends spec for meson is meson@0.61.1: that means it should allow any newer version even though 0.61.1 itself is not packaged, right?

I don't have insights on the non-meson related parts of this PR, but your fix to support newer versions of meson (in advance of the upcoming release where this check is removed upstream) LGTM.

@kjrstory
Copy link
Contributor Author

kjrstory commented Jun 8, 2023

Would someone kindly consider merging or reviewing this pull request (PR)? I would greatly appreciate your time and expertise in providing feedback or incorporating the changes.

alalazo
alalazo requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few minor requests

var/spack/repos/builtin/packages/su2/package.py Show resolved Hide resolved
var/spack/repos/builtin/packages/su2/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/su2/package.py Outdated Show resolved Hide resolved
@alalazo alalazo self-assigned this Jun 12, 2023
@alalazo alalazo enabled auto-merge (squash) June 13, 2023 07:21
@alalazo
Copy link
Member

alalazo commented Jun 13, 2023

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Jun 13, 2023

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details 
pr head: cf288b7, gitlab commit parents: ['e733b87', '617c216']

kjrstory and others added 5 commits June 13, 2023 10:42
@kjrstory @alalazo
SU2: Update new versions and many variants
9975bf2
@kjrstory @alalazo
Update var/spack/repos/builtin/packages/su2/package.py
21a2c06 
depends_on "cmake" only when build

Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
@kjrstory @alalazo
Update var/spack/repos/builtin/packages/su2/package.py
d21373f 
depends on "swig" only during the build process

Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
@kjrstory @alalazo
SU2: add brief comment of meson_version.patch
9bcef0f
@kjrstory @alalazo
Small style fix
7529f35
@alalazo alalazo merged commit 4fe76f9 into spack:develop Jun 13, 2023
12 checks passed
@kjrstory kjrstory deleted the package/su2 branch June 14, 2023 14:02
@kjrstory kjrstory mentioned this pull request Jun 15, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz left review comments

@alalazo alalazo alalazo approved these changes

Assignees

@alalazo alalazo

Labels
dependencies new-variant new-version patch update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kjrstory @alalazo @eli-schwartz