Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podio: Add a variant for rntuple #38851

Closed
wants to merge 3 commits into from
Closed

Conversation

jmcarcell
Copy link
Contributor

Possible after AIDASoft/podio#395

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variant is being applied to a version not listed in the package. Is the version supposed to be included? Or is the starting version in the when argument wrong?

@tldahlgren tldahlgren self-assigned this Jul 11, 2023
@jmcarcell
Copy link
Contributor Author

Yes the version doesn't exist yet, but since the PR in the post has already been merged it will be part of the next one so these changes will pick it up and our nightly system can make use of already even if that version doesn't exist once it's in the recipe. Waiting for the next version is also fine

@jmcarcell
Copy link
Contributor Author

Closed in favor of #40182

@jmcarcell jmcarcell closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants