Add develop version to ufs-weather-model (major updates) #39265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
conflicts
dependencies
new-variant
new-version
update-package
labels
t-brown
reviewed
Aug 3, 2023
t-brown
approved these changes
Aug 4, 2023
becker33
previously requested changes
Sep 13, 2023
|
@becker33 I took out the architecture settings since I don't think we need them for the spack recipe anyway (they're for configuring specific sites which we don't care about), so this way it'll just configure those settings through SPACK_TARGET_ARGS. |
There was a problem hiding this comment.
I'm happy to take over reviewing for @becker33. My B.S. was in Earth Science and I'm now working on ML weather forecasting, so I have some interest in seeing UFS improved.
adamjstewart
approved these changes
May 22, 2024
adamjstewart
dismissed
becker33’s stale review
Change requests have been resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a develop version to the ufs-weather-model recipe, which includes major updates to variants and dependencies. Tested with ATM, S2SW, and ATMAERO configurations to cover all dependencies.
Fixes JCSDA/spack-stack#377