Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: set cache and config dir correctly #39829

Merged
merged 7 commits into from
Sep 6, 2023
Merged

gitlab: set cache and config dir correctly #39829

merged 7 commits into from
Sep 6, 2023

Conversation

haampie
Copy link
Member

@haampie haampie commented Sep 5, 2023

Otherwise it's not picked up in some jobs like cray-generate, which may explain some spurious failure we're seeing

@spackbot-app spackbot-app bot added core PR affects Spack core functionality gitlab Issues related to gitlab integration labels Sep 5, 2023
@haampie
Copy link
Member Author

haampie commented Sep 5, 2023 •
edited

@kwryankrattiger looks like interpolation works fine in top-level .gitlab-ci.yml

$ echo "$SPACK_USER_CACHE_PATH"
/home/gitlab-runner-2/builds/sHxyxvUp/0/spack/spack/tmp/_user_cache/

@haampie haampie changed the title gitlab: move cache dir to any-job gitlab: set cache dir correctly Sep 5, 2023
@haampie haampie changed the title gitlab: set cache dir correctly gitlab: set cache and config dir correctly Sep 5, 2023
@haampie
Copy link
Member Author

haampie commented Sep 5, 2023 •
edited

@kwryankrattiger I guess Spack is interpolating the variable in any-job though ;) or maybe not. In any case, I decided not to change the export SPACK_USER_CACHE_PATH there.

@tldahlgren
Copy link
Contributor

Curious. Is this PR expected to resolve the Error: unhashable type: 'list' error I'm seeing in multiple PRs:

@tldahlgren
Copy link
Contributor

Curious. Is this PR expected to resolve the Error: unhashable type: 'list' error I'm seeing in multiple PRs:

I'm seeing the failure I mentioned above in more PRs.

@haampie
Copy link
Member Author

haampie commented Sep 6, 2023

Hopefully yes 👍

@alalazo alalazo merged commit d80bc70 into spack:develop Sep 6, 2023
34 checks passed
@haampie haampie deleted the fix/gitlab-ci-variable branch September 6, 2023 06:18
mpokorny pushed a commit to mpokorny/spack that referenced this pull request Sep 18, 2023
@haampie @mpokorny
gitlab: set cache and config dir in top-level file (spack#39829)
f2e5264
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Sep 25, 2023
@haampie @RikkiButler20
gitlab: set cache and config dir in top-level file (spack#39829)
3de726a
jhdavis8 pushed a commit to hpcgroup/spack that referenced this pull request Sep 30, 2023
@haampie @jhdavis8
gitlab: set cache and config dir in top-level file (spack#39829)
7ecbc69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalazo alalazo alalazo approved these changes

@kwryankrattiger kwryankrattiger Awaiting requested review from kwryankrattiger

@scottwittenburg scottwittenburg Awaiting requested review from scottwittenburg

Assignees
No one assigned
Labels
core PR affects Spack core functionality gitlab Issues related to gitlab integration new-variant update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haampie @tldahlgren @alalazo