Always apply Python unixcompilers.py rpath fix, not just on cray
#39929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s var/spack/repos/builtin/packages/python/rpath-non-gcc.patch and apply unconditionally
spackbot-app
bot
requested review from
adamjstewart,
scheibelp and
skosukhin
3 tasks
adamjstewart
requested changes
Sep 11, 2023
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
adamjstewart
approved these changes
Sep 11, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
AdhocMan
pushed a commit
to AdhocMan/spack
that referenced
this pull request
Oct 10, 2023
…pack#39929) * Rename var/spack/repos/builtin/packages/python/cray-rpath-3.1.patch as var/spack/repos/builtin/packages/python/rpath-non-gcc.patch and apply unconditionally * Update var/spack/repos/builtin/packages/python/package.py Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> --------- Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the conversation in the spack slack channel (https://spackpm.slack.com/archives/C5W7NKZJT/p1694393880262699), it was concluded that it would be safe to unconditionally apply the patch for the
rpathlinker flag in spack's Python installation, not just when the system is detected as Cray. The need for this came up when building on a Cray that was detected as a "new" Cray due to itscraypeversion, but that still required using the Cray compiler wrappers.Since there are no compilers in spack that understand
-Rbut don't understand-Wl,-R, it's safe to apply this patch regardless of the platform.Actual change: rename
var/spack/repos/builtin/packages/python/cray-rpath-3.1.patchasvar/spack/repos/builtin/packages/python/rpath-non-gcc.patchand apply unconditionally.Testing
Tested on the Navy's Narwhal machine (Cray) and a couple of other HPCs (non Cray) with GNU and Intel.