py-tables: add v3.8.0

[adamjstewart]

Trying to debug #40223 but this latest version also has issues. Going to open an issue upstream.

[spackbot-app]

Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

• py-blosc2
• py-ndindex

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("adamjstewart")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-blosc2

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

[adamjstewart]

Note that I'm unable to test this, so this PR shouldn't be merged unless someone else can confirm it builds correctly.

[tldahlgren]

Confirmed homepages and (new) version sha256.

[manuelakuhn]

Also py-tables does not build for me with the error

     15      Preparing metadata (pyproject.toml): started
     16      Running command Preparing metadata (pyproject.toml)
     17      /tmp/lzo_version_daten6_8cnwo.c: In function 'main':
     18      /tmp/lzo_version_daten6_8cnwo.c:2:5: warning: implicit declaration of function 'lzo_version_date' [-W
           implicit-function-declaration]
     19          2 |     lzo_version_date();
     20            |     ^~~~~~~~~~~~~~~~
  >> 21    /usr/bin/ld: cannot find -llzo2: No such file or directory
  >> 22      collect2: error: ld returned 1 exit status
     23      /tmp/lzo_version_date7u3iiqnr.c: In function 'main':
     24      /tmp/lzo_version_date7u3iiqnr.c:2:5: warning: implicit declaration of function 'lzo_version_date' [-W
           implicit-function-declaration]
     25          2 |     lzo_version_date();
     26            |     ^~~~~~~~~~~~~~~~
  >> 27      /usr/bin/ld: cannot find -llzo: No such file or directory
  >> 28      collect2: error: ld returned 1 exit status
     29      /tmp/BZ2_bzlibVersionh4rtwokt.c: In function 'main':
     30      /tmp/BZ2_bzlibVersionh4rtwokt.c:2:5: warning: implicit declaration of function 'BZ2_bzlibVersion' [-W
           implicit-function-declaration]
     31          2 |     BZ2_bzlibVersion();
     32            |     ^~~~~~~~~~~~~~~~
  >> 33      /usr/bin/ld: cannot find -lbz2: No such file or directory
  >> 34      collect2: error: ld returned 1 exit status
     35      /tmp/blosc2_list_compressors0ckok9tf.c: In function 'main':
     36      /tmp/blosc2_list_compressors0ckok9tf.c:2:5: warning: implicit declaration of function 'blosc2_list_co
           mpressors' [-Wimplicit-function-declaration]
     37          2 |     blosc2_list_compressors();
     38            |     ^~~~~~~~~~~~~~~~~~~~~~~
  >> 39      /usr/bin/ld: cannot find -lblosc2: No such file or directory
  >> 40      collect2: error: ld returned 1 exit status

[manuelakuhn]

depends_on("hdf5@1.10.5:", when="@3.8.0:")

see req_versions.py#12

[adamjstewart]

Thanks @manuelakuhn. If you have time, can you try to get those working? Even if I fix those I can't build with Apple Clang 15 so it's hard for me to debug until we get that fixed. If you don't have time, I can try to see how far I can get tomorrow.

[manuelakuhn]

I will try. So far I can tell that running spack install py-tables+lzo+bzip2 gets rid of all errors except of the one for -lblosc2, so it seems that those are not optional dependencies.

[manuelakuhn]

depends_on("c-blosc2@2.5.0:", when="@3.8:")

and further down

        if "^c-blosc2" in self.spec:
            env.set("BLOSC2_DIR", self.spec["c-blosc2"].prefix)

see req_versions.py#L14

Sorry overlooked this before, but I still get the

  .. ERROR:: Unable to find the blosc2 library.

[manuelakuhn]

I found this issue which seems to have the same problem. The patch they say we should use does not apply on 3.8.0.
I did some tests with the master branch and this builds just fine (when c-blosc2 is added to the spack recipe). According to their timeline in the release/3.9.0 branch they plan to release 3.9.0 today. So maybe we should wait till this is out and work from there.

[manuelakuhn]

Release 3.9.0 installs fine even without an external c-blosc2 dependency and also no variants needed. Will open a pull request.