New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HEP cloud_pipeline stack #40932
base: develop
Are you sure you want to change the base?
Conversation
3f41b75
to
02cba0b
Compare
6c990f9
to
969fe85
Compare
969fe85
to
3566ba1
Compare
I assume this is still a work in progress. Let me know when it's ready to be merged. |
1806871
to
7d10c3c
Compare
This finally builds the hep cloud pipeline. Remaining failure is the chai issue in https://spackpm.slack.com/archives/C02N33GM28H/p1713298552011109?thread_ts=1713298552.011109&cid=C02N33GM28H. |
@jmcarcell Do you want to review this and indicate what else would be useful to add here, based on what packages and variants you depend on in key4hep? @alalazo At this point this is unify: false. Is there a preference for unify: when_possible? I don't see other cloud pipelines use when_possible; they only use false (most) or true (only in developer-tools). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I don't think I have anything to add related to the variants.
a547a9e
to
140df2d
Compare
Rebased to pick up #43738 fixing chai build. |
Hi Wouter, I think this is fantastic! Look good to me wrt. variants, I think @andresailer has also taken a look to check that this works for lcg releases. The selection of packages seems good too. The most minmal stack that makes sense to me just needs to include dd4hep ( all variants enabled ), but this seems a good basis. |
This PR adds a high energy physics (HEP) cloud pipeline stack. The goal is to include at least the core packages in HEP, to ensure they are tested when the underlying dependencies are modified or updated. For that reason, many of the variants have been enabled, even if they are not enabled by default.
TODO:
At this point it includes the following packages, but clearly could include a lot more (snapshot updated 2024-04-17):