vtk-m: bump vtk-m 2.1.0 #41351

vicentebolea · 2023-11-30T02:37:59Z

🎉 🎉 🎉

Finally! VTK-m v2.1.0 final release is out.

This bring exiting new features and bugfixes. Find the release notes at https://gitlab.kitware.com/vtk/vtk-m/-/blob/master/docs/changelog/2.1/release-notes.md

Let me know if we need to change anything else in the package

ViB

🎉 🎉 🎉

vicentebolea · 2023-11-30T02:43:49Z

@spackbot fix style

spackbot-app · 2023-11-30T02:43:52Z

Let me see if I can fix that for you!

spackbot-app · 2023-11-30T02:45:00Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/vtk-m/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/vtk-m/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 606 source files
  mypy checks were clean
==> spack style checks were clean

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

kmorel

Looks good to me.

eugeneswalker · 2023-11-30T15:52:12Z

CI failing here:

vtk-m@2.1.0 /y6ooafr %gcc@11.4.0 arch=linux-ubuntu20.04-x86_64_v3 E4S

...
  >> 147    /tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-y6ooafrkb6f4kewifcrcx
            mz5enjmmsbe/spack-src/vtkm/cont/kokkos/internal/DeviceAdapterAlgori
            thmKokkos.h:47:10: fatal error: 'thrust/device_ptr.h' file not foun
            d
     148    #include <thrust/device_ptr.h>
     149             ^~~~~~~~~~~~~~~~~~~~~
     150    1 error generated when compiling for gfx908.
  >> 151    make[2]: *** [vtkm/cont/CMakeFiles/vtkm_cont.dir/build.make:232: vt
            km/cont/CMakeFiles/vtkm_cont.dir/CellLocatorUniformBins.cxx.o] Erro
            r 1
     152    make[2]: *** Waiting for unfinished jobs....
     153    [  6%] Building CXX object vtkm/cont/CMakeFiles/vtkm_cont.dir/CellS
            et.cxx.o
     154    cd /tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-y6ooafrkb6f4kewifc
            rcxmz5enjmmsbe/spack-build-y6ooafr/vtkm/cont && /builds/spack/spack
            /lib/spack/env/gcc/g++ -DVTKMDIY_MPI_AS_LIB -DVTKMDIY_NO_THREADS -D
            vtkm_cont_EXPORTS -I/tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-y
            6ooafrkb6f4kewifcrcxmz5enjmmsbe/spack-src/vtkm/thirdparty/optionpar
            ser -I/tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-y6ooafrkb6f4kew
            ifcrcxmz5enjmmsbe/spack-src/vtkm/thirdparty/diy -I/tmp/root/spack-s
            tage/spack-stage-vtk-m-2.1.0-y6ooafrkb6f4kewifcrcxmz5enjmmsbe/spack
            -src/vtkm/thirdparty/lcl/vtkmlcl -I/tmp/root/spack-stage/spack-stag
            e-vtk-m-2.1.0-y6ooafrkb6f4kewifcrcxmz5enjmmsbe/spack-src -I/tmp/roo
            t/spack-stage/spack-stage-vtk-m-2.1.0-y6ooafrkb6f4kewifcrcxmz5enjmm
            sbe/spack-build-y6ooafr/include -isystem /tmp/root/spack-stage/spac
            k-stage-vtk-m-2.1.0-y6ooafrkb6f4kewifcrcxmz5enjmmsbe/spack-src/vtkm
            /thirdparty/diy/vtkmdiy/include -isystem /tmp/root/spack-stage/spac
            k-stage-vtk-m-2.1.0-y6ooafrkb6f4kewifcrcxmz5enjmmsbe/spack-build-y6
            ooafr/vtkm/thirdparty/diy/vtkmdiy/include/vtkmdiy/mpi -isystem /hom
            e/software/spack/__spack_path_placeholder__/__spack_path_placeholde
            r__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_p
            ath_placeholder__/__spack_path_placeholder__/__spack_path_placehold
            er__/__spack_path_placeholder__/__spack_path_placeh/linux-ubuntu20.
            04-x86_64_v3/gcc-11.4.0/kokkos-3.7.01-3is7m42nmmptmyp5onrxq2lkzjnqw
            jb3/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -Wall
             -Wcast-align -Wextra -Wpointer-arith -Wformat -Wformat-security -W
            shadow -Wunused -fno-common -Wno-unused-function -Wchar-subscripts 
            -Wfloat-conversion -Wodr -ffunction-sections -pthread -MD -MT vtkm/
            cont/CMakeFiles/vtkm_cont.dir/CellSet.cxx.o -MF CMakeFiles/vtkm_con
            t.dir/CellSet.cxx.o.d -o CMakeFiles/vtkm_cont.dir/CellSet.cxx.o -c 
            /tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-y6ooafrkb6f4kewifcrcx
            mz5enjmmsbe/spack-src/vtkm/cont/CellSet.cxx
     155    make[2]: Leaving directory '/tmp/root/spack-stage/spack-stage-vtk-m
            -2.1.0-y6ooafrkb6f4kewifcrcxmz5enjmmsbe/spack-build-y6ooafr'
  >> 156    make[1]: *** [CMakeFiles/Makefile2:2820: vtkm/cont/CMakeFiles/vtkm_
            cont.dir/all] Error 2
     157    make[1]: Leaving directory '/tmp/root/spack-stage/spack-stage-vtk-m
            -2.1.0-y6ooafrkb6f4kewifcrcxmz5enjmmsbe/spack-build-y6ooafr'
  >> 158    make: *** [Makefile:159: all] Error 2

vtk-m@2.1.0 /ybtwkbe %gcc@11.4.0 arch=linux-ubuntu20.04-x86_64_v3 E4S

...
  >> 147    /tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4bvuc
            6jozvbnrfda/spack-src/vtkm/cont/kokkos/internal/DeviceAdapterAlgori
            thmKokkos.h:47:10: fatal error: 'thrust/device_ptr.h' file not foun
            d
     148    #include <thrust/device_ptr.h>
     149             ^~~~~~~~~~~~~~~~~~~~~
     150    1 error generated when compiling for gfx90a.
  >> 151    make[2]: *** [vtkm/cont/CMakeFiles/vtkm_cont.dir/build.make:232: vt
            km/cont/CMakeFiles/vtkm_cont.dir/CellLocatorUniformBins.cxx.o] Erro
            r 1
     152    make[2]: *** Waiting for unfinished jobs....
     153    [  6%] Building CXX object vtkm/cont/CMakeFiles/vtkm_cont.dir/CellS
            et.cxx.o
     154    cd /tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4b
            vuc6jozvbnrfda/spack-build-ybtwkbe/vtkm/cont && /builds/spack/spack
            /lib/spack/env/gcc/g++ -DVTKMDIY_MPI_AS_LIB -DVTKMDIY_NO_THREADS -D
            vtkm_cont_EXPORTS -I/tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-y
            btwkbeqyjwg4ffr4bvuc6jozvbnrfda/spack-src/vtkm/thirdparty/optionpar
            ser -I/tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ff
            r4bvuc6jozvbnrfda/spack-src/vtkm/thirdparty/diy -I/tmp/root/spack-s
            tage/spack-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4bvuc6jozvbnrfda/spack
            -src/vtkm/thirdparty/lcl/vtkmlcl -I/tmp/root/spack-stage/spack-stag
            e-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4bvuc6jozvbnrfda/spack-src -I/tmp/roo
            t/spack-stage/spack-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4bvuc6jozvbnr
            fda/spack-build-ybtwkbe/include -isystem /tmp/root/spack-stage/spac
            k-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4bvuc6jozvbnrfda/spack-src/vtkm
            /thirdparty/diy/vtkmdiy/include -isystem /tmp/root/spack-stage/spac
            k-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4bvuc6jozvbnrfda/spack-build-yb
            twkbe/vtkm/thirdparty/diy/vtkmdiy/include/vtkmdiy/mpi -isystem /hom
            e/software/spack/__spack_path_placeholder__/__spack_path_placeholde
            r__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_p
            ath_placeholder__/__spack_path_placeholder__/__spack_path_placehold
            er__/__spack_path_placeholder__/__spack_path_placeh/linux-ubuntu20.
            04-x86_64_v3/gcc-11.4.0/kokkos-3.7.01-zuovofah5eeosjceg6e7ktvc457fk
            z72/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -Wall
             -Wcast-align -Wextra -Wpointer-arith -Wformat -Wformat-security -W
            shadow -Wunused -fno-common -Wno-unused-function -Wchar-subscripts 
            -Wfloat-conversion -Wodr -ffunction-sections -pthread -MD -MT vtkm/
            cont/CMakeFiles/vtkm_cont.dir/CellSet.cxx.o -MF CMakeFiles/vtkm_con
            t.dir/CellSet.cxx.o.d -o CMakeFiles/vtkm_cont.dir/CellSet.cxx.o -c 
            /tmp/root/spack-stage/spack-stage-vtk-m-2.1.0-ybtwkbeqyjwg4ffr4bvuc
            6jozvbnrfda/spack-src/vtkm/cont/CellSet.cxx
     155    make[2]: Leaving directory '/tmp/root/spack-stage/spack-stage-vtk-m
            -2.1.0-ybtwkbeqyjwg4ffr4bvuc6jozvbnrfda/spack-build-ybtwkbe'
  >> 156    make[1]: *** [CMakeFiles/Makefile2:2820: vtkm/cont/CMakeFiles/vtkm_
            cont.dir/all] Error 2
     157    make[1]: Leaving directory '/tmp/root/spack-stage/spack-stage-vtk-m
            -2.1.0-ybtwkbeqyjwg4ffr4bvuc6jozvbnrfda/spack-build-ybtwkbe'
  >> 158    make: *** [Makefile:159: all] Error 2

tldahlgren

Confirmed the version sha256, rest LGTM.

vicentebolea · 2023-12-01T03:15:33Z

Gitlab CI error is fixed and we have already merged in upstream the fix.

eugeneswalker · 2023-12-01T03:57:31Z

Should we wait for more review or proceed w merge now?

vicentebolea · 2023-12-01T04:10:09Z

It is ready to merge from my side

…

On Thu, Nov 30, 2023, 22:57 eugeneswalker ***@***.***> wrote: Should we wait for more review or proceed w merge now? — Reply to this email directly, view it on GitHub <#41351 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHFOFR5LDSIEAN4PZMUTFLYHFITNAVCNFSM6AAAAABAAOUJKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVGQYTOMZZG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

* vtk-m: bump vtk-m 2.1.0 * Update package.py * Update package.py

spackbot-app bot added new-version update-package labels Nov 30, 2023

spackbot-app bot requested a review from kmorel November 30, 2023 02:38

vtk-m: bump vtk-m 2.1.0

a5c135e

vicentebolea force-pushed the update-vtkm branch from 51f5965 to a5c135e Compare November 30, 2023 02:46

kmorel approved these changes Nov 30, 2023

View reviewed changes

Update package.py

4c1d3f2

spackbot-app bot added the dependencies label Nov 30, 2023

tldahlgren previously approved these changes Nov 30, 2023

View reviewed changes

tldahlgren requested a review from eugeneswalker November 30, 2023 20:34

tldahlgren assigned tldahlgren and eugeneswalker Nov 30, 2023

vicentebolea dismissed tldahlgren’s stale review via c0ba181 November 30, 2023 22:36

vicentebolea force-pushed the update-vtkm branch from a9fe8af to c0ba181 Compare November 30, 2023 22:36

spackbot-app bot added the patch label Nov 30, 2023

vicentebolea force-pushed the update-vtkm branch from c0ba181 to 43c710d Compare November 30, 2023 22:37

Update package.py

41d1dd9

vicentebolea force-pushed the update-vtkm branch from 43c710d to 41d1dd9 Compare December 1, 2023 00:43

vicentebolea requested review from kmorel and tldahlgren December 1, 2023 03:16

eugeneswalker approved these changes Dec 1, 2023

View reviewed changes

eugeneswalker merged commit 17c87b4 into spack:develop Dec 1, 2023
13 checks passed

vicentebolea deleted the update-vtkm branch December 1, 2023 18:07

greenc-FNAL mentioned this pull request Dec 5, 2023

Merge from upstream as a base for upstream PRs FNALssi/spack#250

Merged

vicentebolea mentioned this pull request Dec 18, 2023

Vtkm add patch thrust #41757

Open

RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024

vtk-m: bump vtk-m 2.1.0 (spack#41351)

50850f0

* vtk-m: bump vtk-m 2.1.0 * Update package.py * Update package.py

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vtk-m: bump vtk-m 2.1.0 #41351

vtk-m: bump vtk-m 2.1.0 #41351

vicentebolea commented Nov 30, 2023

vicentebolea commented Nov 30, 2023

spackbot-app bot commented Nov 30, 2023

spackbot-app bot commented Nov 30, 2023

kmorel left a comment

eugeneswalker commented Nov 30, 2023

tldahlgren left a comment

vicentebolea commented Dec 1, 2023 •

edited

eugeneswalker commented Dec 1, 2023

vicentebolea commented Dec 1, 2023 via email

vtk-m: bump vtk-m 2.1.0 #41351

vtk-m: bump vtk-m 2.1.0 #41351

Conversation

vicentebolea commented Nov 30, 2023

vicentebolea commented Nov 30, 2023

spackbot-app bot commented Nov 30, 2023

spackbot-app bot commented Nov 30, 2023

kmorel left a comment

Choose a reason for hiding this comment

eugeneswalker commented Nov 30, 2023

tldahlgren left a comment

Choose a reason for hiding this comment

vicentebolea commented Dec 1, 2023 • edited

eugeneswalker commented Dec 1, 2023

vicentebolea commented Dec 1, 2023 via email

vicentebolea commented Dec 1, 2023 •

edited