Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: add v8.0.35, fix build #41602

Merged
merged 1 commit into from
Dec 13, 2023
Merged

mysql: add v8.0.35, fix build #41602

merged 1 commit into from
Dec 13, 2023

Conversation

alalazo
Copy link
Member

@alalazo alalazo commented Dec 12, 2023

fixes #41131

  • Add support for Spack built zlib, libevent, openssl, lz4, zstd

fixes spack#41131

* Add support for Spack built zlib, libevent,
  openssl, lz4, zstd
Copy link

spackbot-app bot commented Dec 12, 2023

Hi @alalazo! I noticed that the following package(s) don't yet have maintainers:

  • mysql

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("alalazo")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame mysql

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@alalazo
Copy link
Member Author

alalazo commented Dec 12, 2023

@EbiArnie

@EbiArnie
Copy link
Contributor

Would you like me to do a review or become maintainer?

As for the change: Looks sensible. Builds and works for me, mysql_config has the right (Spack) dependencies.
Built with linux-ubuntu22.04-x86_64_v3/gcc-11.4.0, mysql 8.0.35.

@alalazo
Copy link
Member Author

alalazo commented Dec 13, 2023

Would you like me to do a review or become maintainer?

Sure, feel free to push to the branch

Copy link
Contributor

@EbiArnie EbiArnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@haampie haampie merged commit cd28384 into spack:develop Dec 13, 2023
13 checks passed
@alalazo alalazo deleted the packages/mysql branch December 13, 2023 11:14
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation issue: mysql
3 participants