Fix a bug when a required provider is requested for multiple virtuals #42088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
core
albestro
added a commit
to eth-cscs/DLA-Future
that referenced
this pull request
Jan 18, 2024
relevant PRs got merged in spack/develop - spack/spack#42087 - spack/spack#42088
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 25, 2024
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
alalazo
added a commit
that referenced
this pull request
Feb 9, 2024
alalazo
added a commit
that referenced
this pull request
Feb 29, 2024
tldahlgren
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #42084
When a package is required as a provider for multiple virtuals, it could happen that some of these requirements are not honored. The cause is a too "coarse" formulation of the requirement on the ASP side, which doesn't connect the required virtual and the required package to the same
provider/2fact.The bug has been fixed in this PR.