Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark more tools commonly necessary for builds and config or build-only deps as build-tools #42110

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

trws
Copy link
Contributor

@trws trws commented Jan 16, 2024

This came from #42082, but seems like something we probably want. The main thing is this allows the concretizer to duplicate these where necessary, and they're used as build tools with only build type extremely frequently near the bottom of the stack. Some of those deps are actually dev-only, but we don't have a good way to express that right now so I'm leaving them alone, but at least marking these so we can solve around them.

Copy link

spackbot-app bot commented Jan 16, 2024

Hi @trws! I noticed that the following package(s) don't yet have maintainers:

  • pkgconf
  • sed

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("trws")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame pkgconf

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@trws
Copy link
Contributor Author

trws commented Jan 16, 2024

@adamjstewart, are the py-torchdata errors something a bounce would deal with or should I be looking at a force-merge?

@adamjstewart
Copy link
Member

They are not, working on a PR to fix this now, thanks for letting me know.

@trws trws enabled auto-merge (squash) January 17, 2024 00:59
@trws trws merged commit c05ed2c into spack:develop Jan 17, 2024
24 checks passed
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 25, 2024
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants