Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc: work around -v split between ld and ccld #42111

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

trws
Copy link
Contributor

@trws trws commented Jan 16, 2024

When the cc wrapper gets a -v argument, it currently assumes it's a version check when mode is either ld or unset. That seems right, but it checks the value of mode before ccld is detected. This moves the code down so that -v on gcc in ccld mode gives us the gcc verbose behavior with wrapper args passed rather than adding no wrapper args.

From #42082

@spackbot-app spackbot-app bot added the core PR affects Spack core functionality label Jan 16, 2024
@spackbot-app spackbot-app bot added the tests General test capability(ies) label Jan 16, 2024
@haampie
Copy link
Member

haampie commented Jan 17, 2024

Is it true for all compilers?

@trws
Copy link
Contributor Author

trws commented Jan 17, 2024 via email

@trws trws merged commit c508ff1 into spack:develop Jan 17, 2024
34 checks passed
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 25, 2024
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core PR affects Spack core functionality tests General test capability(ies)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants