Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci: only push in parallel when forking #42143

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

haampie
Copy link
Member

@haampie haampie commented Jan 18, 2024

Process pools don't work when spawning due to globals
Thread pools don't work because Spack is not thread safe

馃帀

@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality tests General test capability(ies) labels Jan 18, 2024
@haampie haampie added this to the v0.21.2 milestone Jan 18, 2024
@alalazo alalazo mentioned this pull request Jan 18, 2024
13 tasks
@alalazo alalazo merged commit cb685b0 into spack:develop Jan 18, 2024
33 of 34 checks passed
@haampie haampie deleted the fix/oci-fork-only branch January 22, 2024 18:07
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 25, 2024
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands core PR affects Spack core functionality tests General test capability(ies)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants