Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whizard: Add version 3.1.4 #43045

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Mar 6, 2024

EDIT: Add a dependency on pythia8 since 3.1.4 is the first version supporting pythia 8.310

Copy link
Contributor

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like 3.1.4 is already on Launchpad. Can you add the new version with updated dependencies instead of the patch?

The new version should also no longer need the parallel build patch (see https://bugs.launchpad.net/whizard/+bug/2053233 )

@jmcarcell jmcarcell changed the title whizard: Add a patch to fix builds with pythia8 >= 8.310 whizard: Add version 3.1.4 Apr 25, 2024
@jmcarcell
Copy link
Contributor Author

Seems like 3.1.4 is already on Launchpad. Can you add the new version with updated dependencies instead of the patch?

The new version should also no longer need the parallel build patch (see bugs.launchpad.net/whizard/+bug/2053233 )

Done but I haven't tested this yet. It will be a few days until I do.

Copy link
Contributor

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tried to build 3.1.4 with pythia 8.310 and in parallel, worked well for me. But I can wait with merging for your tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants