Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hit-rate on buildcaches #43272

Merged
merged 9 commits into from
Apr 5, 2024

Commits on Mar 29, 2024

  1. Relax compiler and target mismatches

    The mismatch occurs on an edge. Previously it was assigned
    the parent priority, now it is assigned to the child
    priority.
    
    This should make reuse from buildcaches or store more likely,
    since most mismatches will be counted with "reused" priority.
    alalazo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    aad77fc View commit details
    Browse the repository at this point in the history
  2. Optimize version badness for runtimes at very low priority

    We don't want to e.g. switch other attributes because we
    cannot reuse an old installed runtime.
    alalazo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5bf52e9 View commit details
    Browse the repository at this point in the history
  3. Optimize runtime attributes at very low priority

    This is such that the version of the runtime would
    not influence whether we should reuse a spec.
    
    Compiler mismatches are considered for runtimes,
    to avoid situations where compiling foo%gcc@9
    brings in gcc-runtime%gcc@13 if gcc@13 is among
    the available compilers
    alalazo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    23480c1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3bdf1bc View commit details
    Browse the repository at this point in the history
  5. Exclude specs without runtimes from reuse

    This should ensure that we do not reuse specs that
    could be broken, as they expect the compiler to be
    installed in a specific place.
    alalazo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ed3b0be View commit details
    Browse the repository at this point in the history
  6. Bump clang version from 12 to 15 in unit-tests

    This is to avoid differences on m1
    with respect to x86_64 machines
    alalazo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c0ce6ed View commit details
    Browse the repository at this point in the history
  7. Bump gcc version from 4.8.0 to 9.4.0 in unit tests

    This is to avoid differences on m1
    with respect to x86_64
    alalazo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    523c704 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    b5439b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0715bab View commit details
    Browse the repository at this point in the history