Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python wheels: do not "expand" #43317

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

haampie
Copy link
Member

@haampie haampie commented Mar 22, 2024

Implement a no-op decompressor for "whl" to make expand=False redundant.

Should be future-proof in the sense that we can identify the mime type of these
file as zip, and discriminate between wheel vs any other zip file by looking for a
*.dist-info/WHEEL file. For now it's file extension based though.

Copy link

spackbot-app bot commented Mar 22, 2024

Hi @haampie! I noticed that the following package(s) don't yet have maintainers:

  • py-azureml-automl-core
  • py-azureml-core
  • py-azureml-dataprep
  • py-azureml-dataprep-native
  • py-azureml-dataprep-rslex
  • py-azureml-dataset-runtime
  • py-azureml-pipeline
  • py-azureml-pipeline-core
  • py-azureml-pipeline-steps
  • py-azureml-telemetry
  • py-azureml-train
  • py-azureml-train-automl-client
  • py-azureml-train-core
  • py-azureml-train-restclients-hyperdrive
  • py-climate
  • py-dotnetcore2
  • py-igor2
  • py-installer
  • py-intel-openmp
  • py-itk
  • py-jupyterlab-pygments
  • py-jupyterlab-widgets
  • py-lightning-api-access
  • py-opencensus-context
  • py-setuptools
  • py-shiboken2
  • py-thop
  • py-tuswsgi
  • py-wheel
  • py-x21

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("haampie")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-azureml-automl-core

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@adamjstewart
Copy link
Member

This is cool. If for whatever reason it doesn't get approved, another thing I've thought about is allowing expand = False at the package level like we do for most other version parameters (url, git, submodule, etc.).

@haampie
Copy link
Member Author

haampie commented Mar 22, 2024

I don't think that's going to be necessary. Only use case for extracting wheels is patching, but at that point we should probably also install them manually instead of relying on pip.

@spackbot-app spackbot-app bot added the tests General test capability(ies) label Mar 22, 2024
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once unit tests are updated 🙂

@alalazo alalazo self-assigned this Mar 22, 2024
@haampie haampie requested a review from alalazo March 22, 2024 13:12
@alalazo alalazo merged commit 434836b into spack:develop Mar 22, 2024
32 of 34 checks passed
@haampie haampie deleted the feature/wheel-do-not-expand branch March 22, 2024 17:01
mathomp4 pushed a commit to mathomp4/spack that referenced this pull request Mar 27, 2024
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core PR affects Spack core functionality intel new-version python tests General test capability(ies) update-package utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants