-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python wheels: do not "expand" #43317
Conversation
Hi @haampie! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("haampie") If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame py-azureml-automl-core Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
This is cool. If for whatever reason it doesn't get approved, another thing I've thought about is allowing |
I don't think that's going to be necessary. Only use case for extracting wheels is patching, but at that point we should probably also install them manually instead of relying on pip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once unit tests are updated 🙂
Implement a no-op decompressor for "whl" to make
expand=False
redundant.Should be future-proof in the sense that we can identify the mime type of these
file as zip, and discriminate between wheel vs any other zip file by looking for a
*.dist-info/WHEEL
file. For now it's file extension based though.