Windows: automatic GL detection during bootstrap #43459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheibelp
requested changes
Apr 4, 2024
scheibelp
reviewed
Apr 16, 2024
scheibelp
approved these changes
Apr 18, 2024
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
Apr 23, 2024
On Windows, bootstrapping logic now searches for and adds the win-sdk and wgl packages to the user's top scope as externals if they are not present. These packages are generally required to install most packages with Spack on Windows, and are only available as externals, so it is assumed that doing this automatically would be useful and avoid a mandatory manual step for each new Spack instance. Note this is the first case of bootstrapping logic modifying configuration other than the bootstrap configuration.
johnwparent
added a commit
that referenced
this pull request
Apr 24, 2024
…)" This reverts commit 9e2558b.
haampie
pushed a commit
that referenced
this pull request
Apr 24, 2024
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Apr 29, 2024
On Windows, bootstrapping logic now searches for and adds the win-sdk and wgl packages to the user's top scope as externals if they are not present. These packages are generally required to install most packages with Spack on Windows, and are only available as externals, so it is assumed that doing this automatically would be useful and avoid a mandatory manual step for each new Spack instance. Note this is the first case of bootstrapping logic modifying configuration other than the bootstrap configuration.
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Apr 29, 2024
…k#43459)" (spack#43819) This reverts commit 9e2558b.
scheibelp
pushed a commit
that referenced
this pull request
May 2, 2024
Adds a pre-concretization check for the Windows SDK and WGL (Windows GL) packages as non-buildable externals. This is a redo of #43459, but makes sure to modify the configuration scope outside of the bootstrap scope: whichever is highest-precedence in the user's environment at the time the concretization runs, which should either be an env scope or the ~ scope. Adds pytest fixture mocking the check for WGL and WSDK as if they were present.
wdconinc
pushed a commit
that referenced
this pull request
May 4, 2024
wdconinc
pushed a commit
that referenced
this pull request
May 4, 2024
Adds a pre-concretization check for the Windows SDK and WGL (Windows GL) packages as non-buildable externals. This is a redo of #43459, but makes sure to modify the configuration scope outside of the bootstrap scope: whichever is highest-precedence in the user's environment at the time the concretization runs, which should either be an env scope or the ~ scope. Adds pytest fixture mocking the check for WGL and WSDK as if they were present.
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
May 8, 2024
Adds a pre-concretization check for the Windows SDK and WGL (Windows GL) packages as non-buildable externals. This is a redo of spack#43459, but makes sure to modify the configuration scope outside of the bootstrap scope: whichever is highest-precedence in the user's environment at the time the concretization runs, which should either be an env scope or the ~ scope. Adds pytest fixture mocking the check for WGL and WSDK as if they were present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require users of Spack on Windows installed the Windows SDK alongside VS (this is one extra box to click) which will guarantee we have WGL available during Spack runs (bundled as part of the sdk).
Detect WGL as part of the bootstrapping run, and if not found, do not allow Spack to complete the bootstrap. If not found, inform users to install as part of the Windows SDK.
This brings Windows up to parity with other platforms, where detecting a GL provider is done automatically, or GL providers can be built natively.