Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-simpy: New package #43497

Merged
merged 7 commits into from May 1, 2024
Merged

py-simpy: New package #43497

merged 7 commits into from May 1, 2024

Conversation

alex391
Copy link
Contributor

@alex391 alex391 commented Apr 4, 2024

No description provided.

Copy link

spackbot-app bot commented Apr 4, 2024

Hi @alex391! I noticed that the following package(s) don't yet have maintainers:

  • py-setuptools-scm
  • py-simpy

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("alex391")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-setuptools-scm

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@alex391 alex391 marked this pull request as draft April 4, 2024 20:01
@alex391 alex391 marked this pull request as ready for review April 4, 2024 20:06
@alex391
Copy link
Contributor Author

alex391 commented Apr 8, 2024

How should I fix this gitlab-ci error?

@alex391
Copy link
Contributor Author

alex391 commented Apr 16, 2024

@spackbot re-run pipeline

Copy link

spackbot-app bot commented Apr 16, 2024

I've started that pipeline for you!

@alex391 alex391 marked this pull request as draft April 24, 2024 20:26
@alex391 alex391 marked this pull request as ready for review April 24, 2024 20:41
@wdconinc wdconinc self-assigned this Apr 30, 2024
Because versions @:7 have an underscore (setuptools_scm) in the URL, and
newer versions have a dash (setuptools-scm).
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed install on two new py-simpy versions, and with setuptools 7.1.0 as well for the older version:

# spack find -lv py-simpy
-- linux-ubuntu20.04-x86_64_v3 / gcc@11.4.0 ---------------------
ntclwdq py-simpy@4.0.2 build_system=python_pip  xoniath py-simpy@4.0.2 build_system=python_pip  pcqqlwl py-simpy@4.1.1 build_system=python_pip
==> 3 installed packages

@wdconinc wdconinc enabled auto-merge (squash) May 1, 2024 16:56
@wdconinc
Copy link
Contributor

wdconinc commented May 1, 2024

Thanks for the contribution. Enabled auto-merge, but pipelines are running a bit behind from what I see on slack due to some changes in core packages.

@alex391
Copy link
Contributor Author

alex391 commented May 1, 2024

Thank you for the review @wdconinc!

@wdconinc wdconinc merged commit 38c49d6 into spack:develop May 1, 2024
14 checks passed
wdconinc pushed a commit that referenced this pull request May 4, 2024
* pypi build of py-simpy

* [py-simpy] toml explicitly called out

* py-simpy: New version

* py-setuptools-scm: Added new version

* py-setuptools-scm: add url_for_version

Because versions @:7 have an underscore (setuptools_scm) in the URL, and
newer versions have a dash (setuptools-scm).

* py-setuptools-scm: fix flake8 line too long

* py-simpy: Fix hash

---------

Co-authored-by: Sid Pendelberry <sid@rit.edu>
Co-authored-by: Jen Herting <jen@herting.cc>
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request May 8, 2024
* pypi build of py-simpy

* [py-simpy] toml explicitly called out

* py-simpy: New version

* py-setuptools-scm: Added new version

* py-setuptools-scm: add url_for_version

Because versions @:7 have an underscore (setuptools_scm) in the URL, and
newer versions have a dash (setuptools-scm).

* py-setuptools-scm: fix flake8 line too long

* py-simpy: Fix hash

---------

Co-authored-by: Sid Pendelberry <sid@rit.edu>
Co-authored-by: Jen Herting <jen@herting.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants