Enable MacOS, Sonoma (OS version 14.x) building of FMS and MAPL #43726
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e were causing builds to fail on MacOS and CMake appears to handle the build fine without the mpi wrappers.
spackbot-app
bot
requested review from
AlexanderRichert-NOAA,
climbfuji,
edwardhartnett,
Hang-Lei-NOAA,
mathomp4 and
tclune
|
@rem1776 can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
mathomp4
approved these changes
Apr 18, 2024
climbfuji
approved these changes
Apr 18, 2024
|
I want to test these on a couple systems to be safe, I'll update once that's done. 🙏 |
|
Please note that I tested this only on my Mac laptop using the JCSDA jedi-bundle, which exercises FMS but does not exercise MAPL, and I realize that this is not very extensive. Thank you @AlexanderRichert-NOAA for expanding the testing coverage! |
AlexanderRichert-NOAA
approved these changes
Apr 18, 2024
tldahlgren
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the package.py scripts for the FMS and MAPL packages. These changes enabled the building of FMS and MAPL on the MacOS, Sonoma (14) with the Xcode 15.1 (apple clang 15.0.0) tools.
The primary update is to remove the usage of the MPI wrappers to build FMS and MAPL. Since these two packages use CMake, the wrappers should not be necessary. However, I realize that there were likely reasons for using the wrappers so this solution may not be viable.
I think if we can get by without the MPI wrappers, great! But I'm fine with keeping the MPI wrappers and open to other solutions. In this case, perhaps a conditional (based on MacOS for example) removal of the wrappers would be workable?
Partially addresses JCSDA/spack-stack/pull/1083. Still need to get these changes merged into the JCSDA spack fork to complete the resolution of this issue.