Fix a bug preventing to set platform= on externals
#43758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
core
alalazo
removed
the
stand-alone-tests
|
Benchmark:
radiuss.develop.csv
There is a spike on |
haampie
approved these changes
Apr 22, 2024
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
Apr 23, 2024
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43406
Previously there was an issue specifically with
platform, because it was the only node attribute that wasn't created out of a choice rule. Setting it from externals created a conflict with rules containingnot platform_set.