Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Add new versions #43835

Closed
wants to merge 2 commits into from

Conversation

jrood-nrel
Copy link
Member

It doesn't seem like these have been updated in a bit. I also elected to not change the current default version.

@alalazo
Copy link
Member

alalazo commented Apr 25, 2024

See #43349 and #43723

@spack spack deleted a comment from spackbot-app bot Apr 25, 2024
@alalazo
Copy link
Member

alalazo commented Apr 25, 2024

@spackbot fix style

Copy link

spackbot-app bot commented Apr 25, 2024

Let me see if I can fix that for you!

@alalazo alalazo self-assigned this Apr 25, 2024
Copy link

spackbot-app bot commented Apr 25, 2024

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/cmake/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/cmake/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 622 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@jrood-nrel
Copy link
Member Author

Ah, I assumed CMake would have more activity so that makes sense. I should have searched PRs. Feel free to close this.

@johnwparent
Copy link
Contributor

Ah, I assumed CMake would have more activity so that makes sense. I should have searched PRs. Feel free to close this.

Closing in favor of the other linked PRs here, but thanks for staying on top of the CMake updates!

@jrood-nrel jrood-nrel deleted the jrood/cmake-versions branch May 3, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants