Ignore external packages when pushing to buildcache automatically (--autopush) #43930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haampie
approved these changes
May 2, 2024
wdconinc
pushed a commit
that referenced
this pull request
May 4, 2024
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
May 8, 2024
arezaii
pushed a commit
to arezaii/spack
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed failures attempting to populate a build cache using
--autopushwith a spec that had external packages.It turns out that the corresponding hook wasn’t ignoring external packages as the buildcache original logic does:
spack/lib/spack/spack/binary_distribution.py
Line 1255 in 62554ce
This PR adds the missing logic.
@haampie