MFEM: add new version v4.7 #44010

v-dobrev · 2024-05-05T01:44:00Z

TODO:

After MFEM v4.7 is released, update the source for that in mfem/package.py
Add new variant for precision: double, or single; available since v4.7
Address MFEM : c++ standard variant and expose configuration options #41673
Address mfem: Extract setup of mfem's configuration options into separate function #44427 (comment)

* Fix the build when the cuda variant is disabled and cuda is present on the system. * In the 'libs' property, search for the libraries in the whole prefix, not just in 'lib' -- newer versions use 'lib64' at least in some cases. * Propagate the 'make_jobs' setting to the build system -- it requires a special flag in the make options.

path_from_modules(...) to the rpaths when it returns None. The presense of None in the rpaths was causing an issue.

'-std=c89' -- without it the build fails.

the code.

… was causing the PETSc configuration to fail.

…nmp' to the SuiteSparse build system. Add backward compatibility support for new SuiteSparse versions which moved the SuiteSparse headers inside a subdirectory 'suitesparse' -- to allow existing packages to work with these new versions, all headers from the 'suitesparse' subdirectory are linked in the parent directory, '<prefix>/include'. Added new version: v7.7.0.

during testing through Spack. Added various tweaks and fixes in the package and updated the testing script 'test_builds.sh'.

v-dobrev · 2024-05-17T00:03:11Z

@spackbot fix style

spackbot-app · 2024-05-17T00:03:14Z

Let me see if I can fix that for you!

spackbot-app · 2024-05-17T00:04:27Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  lib/spack/spack/build_environment.py
  var/spack/repos/builtin/packages/hiop/package.py
  var/spack/repos/builtin/packages/metis/package.py
  var/spack/repos/builtin/packages/mfem/package.py
  var/spack/repos/builtin/packages/petsc/package.py
  var/spack/repos/builtin/packages/suite-sparse/package.py
  var/spack/repos/builtin/packages/zlib-ng/package.py
==> Running isort checks
Fixing /tmp/tmp0qna4rvk/spack/var/spack/repos/builtin/packages/suite-sparse/package.py
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/metis/package.py
reformatted var/spack/repos/builtin/packages/suite-sparse/package.py
reformatted var/spack/repos/builtin/packages/zlib-ng/package.py
reformatted var/spack/repos/builtin/packages/mfem/package.py
All done! ✨ 🍰 ✨
4 files reformatted, 3 files left unchanged.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 625 source files)
  mypy found errors

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

v-dobrev · 2024-05-24T17:43:11Z

@spackbot fix style

spackbot-app · 2024-05-24T17:43:14Z

Let me see if I can fix that for you!

spackbot-app · 2024-05-24T17:44:34Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  lib/spack/spack/build_environment.py
  var/spack/repos/builtin/packages/hiop/package.py
  var/spack/repos/builtin/packages/hypre/package.py
  var/spack/repos/builtin/packages/metis/package.py
  var/spack/repos/builtin/packages/mfem/package.py
  var/spack/repos/builtin/packages/petsc/package.py
  var/spack/repos/builtin/packages/suite-sparse/package.py
  var/spack/repos/builtin/packages/zlib-ng/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/mfem/package.py
All done! ✨ 🍰 ✨
1 file reformatted, 7 files left unchanged.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 625 source files)
  mypy found errors

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

'ld_flags_from_dirs' as methods of class 'Mfem' so that they can be reused by sub-classes.

v-dobrev · 2024-05-30T00:42:31Z

@spackbot fix style

spackbot-app · 2024-05-30T00:42:34Z

Let me see if I can fix that for you!

spackbot-app · 2024-05-30T00:44:00Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  lib/spack/spack/build_environment.py
  var/spack/repos/builtin/packages/hiop/package.py
  var/spack/repos/builtin/packages/hypre/package.py
  var/spack/repos/builtin/packages/metis/package.py
  var/spack/repos/builtin/packages/mfem/package.py
  var/spack/repos/builtin/packages/petsc/package.py
  var/spack/repos/builtin/packages/suite-sparse/package.py
  var/spack/repos/builtin/packages/zlib-ng/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/mfem/package.py
All done! ✨ 🍰 ✨
1 file reformatted, 7 files left unchanged.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 625 source files)
  mypy found errors

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

kennyweiss

Thanks @v-dobrev!

[mfem] Initial changes for mfem-4.7

1ce1416

v-dobrev added new-version WIP xSDK update-package e4s labels May 5, 2024

v-dobrev requested review from tzanio and acfisher May 5, 2024 01:44

v-dobrev self-assigned this May 5, 2024

spackbot-app bot requested a review from markcmiller86 May 5, 2024 01:44

v-dobrev added the don't-merge-yet label May 5, 2024

v-dobrev added 5 commits May 4, 2024 19:16

[mfem] remove extra space from branch name

9d826bc

[mfem] New versions of 'umpire' may require linking with 'fmt'

6b8469d

[mfem] Updates in the testing script for v4.7

8d63939

[mfem] Replace mfem-4.7-dev branch with the official release link

4961dae

spackbot-app bot added the patch label May 7, 2024

v-dobrev added 7 commits May 16, 2024 16:05

[hiop] Some correction in the HiOp package

ed0c10c

[build_environment.py] In get_rpaths(pkg), do not add the result of

5151b7b

path_from_modules(...) to the rpaths when it returns None. The presense of None in the rpaths was causing an issue.

[metis] When compiling 'metis@4.0.3' with 'cce@17:', add the flag

e47a3ac

'-std=c89' -- without it the build fails.

[zlib-ng] Fix an issue in the 'libs' property, descibed in a comment in

c167b0c

the code.

[petsc] Fix an issue where deprecation warnings from HIP/ROCm headers…

16a698e

… was causing the PETSc configuration to fail.

[mfem] Added a patch for mfem-4.7 to fix a few small issues noticed

2ee5075

during testing through Spack. Added various tweaks and fixes in the package and updated the testing script 'test_builds.sh'.

spackbot-app bot added build-environment conflicts core PR affects Spack core functionality dependencies labels May 16, 2024

Merge branch 'develop' into packages/mfem-4.7

af9e44d

[@spackbot] updating style on behalf of v-dobrev

29af91d

alalazo self-assigned this May 17, 2024

v-dobrev added 2 commits May 23, 2024 17:34

[hypre] Add 'precision' variant

600add1

[mfem] Add 'precision' variant

9dafa18

spackbot-app bot added the new-variant label May 24, 2024

[mfem] Add 'cxxstd' variant and other updates to address #41673

ea8cd7d

[@spackbot] updating style on behalf of v-dobrev

0cce271

This was referenced May 24, 2024

MFEM : c++ standard variant and expose configuration options #41673

Open

mfem: Extract setup of mfem's configuration options into separate function #44427

Closed

[mfem] define the functions 'ld_flags_from_library_list' and

ba2df61

'ld_flags_from_dirs' as methods of class 'Mfem' so that they can be reused by sub-classes.

[@spackbot] updating style on behalf of v-dobrev

b50e324

kennyweiss approved these changes May 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MFEM: add new version v4.7 #44010

MFEM: add new version v4.7 #44010

v-dobrev commented May 5, 2024 •

edited

v-dobrev commented May 17, 2024

spackbot-app bot commented May 17, 2024

spackbot-app bot commented May 17, 2024

v-dobrev commented May 24, 2024

spackbot-app bot commented May 24, 2024

spackbot-app bot commented May 24, 2024

v-dobrev commented May 30, 2024

spackbot-app bot commented May 30, 2024

spackbot-app bot commented May 30, 2024

kennyweiss left a comment

MFEM: add new version v4.7 #44010

Are you sure you want to change the base?

MFEM: add new version v4.7 #44010

Conversation

v-dobrev commented May 5, 2024 • edited

v-dobrev commented May 17, 2024

spackbot-app bot commented May 17, 2024

spackbot-app bot commented May 17, 2024

v-dobrev commented May 24, 2024

spackbot-app bot commented May 24, 2024

spackbot-app bot commented May 24, 2024

v-dobrev commented May 30, 2024

spackbot-app bot commented May 30, 2024

spackbot-app bot commented May 30, 2024

kennyweiss left a comment

Choose a reason for hiding this comment

v-dobrev commented May 5, 2024 •

edited