Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAX: add v0.4.27, NCCL variant #44071

Merged
merged 1 commit into from
May 8, 2024

Conversation

adamjstewart
Copy link
Member

There is also a flag for ROCm, but I don't have access to an AMD GPU and we no longer have a ML ROCm CI pipeline.

Copy link

spackbot-app bot commented May 8, 2024

@jonas-eschle can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • py-jax

Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Did you try to build it? With the nccl?

@adamjstewart
Copy link
Member Author

I do most development on macOS where I can't quickly test CUDA/NCCL stuff, but we build +cuda (and therefore +nccl) in CI, so it should tell us if there are any issues.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the two version sha256s, rest LGTM.

@tldahlgren tldahlgren self-assigned this May 8, 2024
@tldahlgren tldahlgren merged commit 3148939 into spack:develop May 8, 2024
14 checks passed
@adamjstewart adamjstewart deleted the packages/py-jax branch May 8, 2024 20:49
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request May 8, 2024
arezaii pushed a commit to arezaii/spack that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants