Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastjet: Add a cxxstd variant #44072

Merged
merged 3 commits into from
May 12, 2024
Merged

fastjet: Add a cxxstd variant #44072

merged 3 commits into from
May 12, 2024

Conversation

jmcarcell
Copy link
Contributor

I left 11 as the default since that seems what's being used on my machine by default. I tested building with C++20 and it went fine with GCC 11.4

@tldahlgren
Copy link
Contributor

@drbenmorgan @vvolkl Do either of you want to comment on this PR?

@tldahlgren tldahlgren self-assigned this May 8, 2024
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecbcs
Copy link
Member

alecbcs commented May 10, 2024

@drbenmorgan @vvolkl Do either of you want to comment on this PR?

@drbenmorgan @vvolkl final chance / would you all like to be removed as maintainers of this package?

@alecbcs alecbcs merged commit d594f84 into spack:develop May 12, 2024
14 checks passed
@alecbcs alecbcs self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants