-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libpressio update #44076
libpressio update #44076
Conversation
Hi @robertu94! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("robertu94") If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame py-langsmith Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
457b7d2
to
464d750
Compare
464d750
to
aa4e61e
Compare
eb1949d
to
07943ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the new homepages, commits, and all but one sha256. I am also not able to stage the python package to check dependencies though.
I identified several packages with ordering "issues" (e.g., dependencies before variants). There's a FIXME comment that can be removed (poorjit
). The rest are suggestions.
802b64e
to
3f01113
Compare
3f01113
to
c56dcbb
Compare
@tldahlgren this is ready for you again when you get time. I understand if you guys are busy with ICS. |
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren I didn't intend to include the py-langsmith change here. That package releases super often, and I just needed a working version for something. I wouldn't have added it to spack, but since it was there I updated it so that it worked for me. |
Is this ready to merge or do we still need more changes @tldahlgren ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-confirmed commits and sha256s, rest LGTM.
Various updates for the libpressio ecosystem: