Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpressio update #44076

Merged
merged 7 commits into from
May 21, 2024
Merged

Conversation

robertu94
Copy link
Contributor

@robertu94 robertu94 commented May 8, 2024

Various updates for the libpressio ecosystem:

  • [new] added support for dctz -- a new compressor based on the discrete cosine transform
  • [new] added support for the lc-framework which supports lossless and lossy compressors through preprocessor and components
  • [new] libpressio-adios1 -- support for legacy adios bp files used on SDRBench
  • [new] libpressio-dataset -- tools to load large datasets with platform efficient caching
  • [new] libpressio-predict -- tools to predict compression ratios and other quality metrics for compressors efficiently
  • [new] libpressio-jit -- just in time compilation for compressors developed with libpressio
  • [new] poorjit -- a poor man's jit based on GCC.
  • updated versions for various libpressio packages.

Copy link

spackbot-app bot commented May 8, 2024

Hi @robertu94! I noticed that the following package(s) don't yet have maintainers:

  • py-langsmith

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("robertu94")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-langsmith

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the new homepages, commits, and all but one sha256. I am also not able to stage the python package to check dependencies though.

I identified several packages with ordering "issues" (e.g., dependencies before variants). There's a FIXME comment that can be removed (poorjit). The rest are suggestions.

var/spack/repos/builtin/packages/lc-framework/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/libpressio-jit/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/dctz/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/poorjit/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-langsmith/package.py Outdated Show resolved Hide resolved
@tldahlgren tldahlgren self-assigned this May 8, 2024
@robertu94 robertu94 force-pushed the libpressio-updates-04-24 branch 4 times, most recently from 802b64e to 3f01113 Compare May 11, 2024 17:52
@robertu94
Copy link
Contributor Author

@tldahlgren this is ready for you again when you get time. I understand if you guys are busy with ICS.

Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
@robertu94
Copy link
Contributor Author

@tldahlgren I didn't intend to include the py-langsmith change here. That package releases super often, and I just needed a working version for something. I wouldn't have added it to spack, but since it was there I updated it so that it worked for me.

@robertu94
Copy link
Contributor Author

Is this ready to merge or do we still need more changes @tldahlgren ?

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-confirmed commits and sha256s, rest LGTM.

@tldahlgren tldahlgren enabled auto-merge (squash) May 20, 2024 21:37
@tldahlgren tldahlgren merged commit a94ebfe into spack:develop May 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants