Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-nuitka: new package #44079

Merged
merged 1 commit into from
May 10, 2024
Merged

py-nuitka: new package #44079

merged 1 commit into from
May 10, 2024

Conversation

jamessmillie
Copy link
Contributor

This PR adds the Nuitka python compiler to the builtin packages in Spack

Copy link

spackbot-app bot commented May 8, 2024

Hi @jamessmillie! I noticed that the following package(s) don't yet have maintainers:

  • py-nuitka

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("jamessmillie")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-nuitka

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@alecbcs alecbcs changed the title Add py-nuitka package py-nuitka: new package May 8, 2024
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. Confirmed the homepage and version sha256.

Copy link
Member

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I see https://github.com/Nuitka/Nuitka?tab=readme-ov-file#c-compiler is fairly specific about which compilers are needed on which systems. I think that these constraints are for packages that use Nuitka to build - possibly for building Nuitka itself, but not just that; if that's correct, then we don't have a great way to express that (i.e. "if I'm using Nuitka to build, then I need one of these compilers"), so I don't think there will be a way to address that quickly. It's an interesting modeling use case though.

@scheibelp scheibelp merged commit 40bf9a1 into spack:develop May 10, 2024
14 checks passed
arezaii pushed a commit to arezaii/spack that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants