Octopus 14.1 : Add new version hash #44083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangohr
approved these changes
May 8, 2024
There was a problem hiding this comment.
@iamashwin99 has tested these changes before (fangohr/octopus-in-spack#110), and they look good to me.
Octopus has changed from autotools to cmake as the preferred build system with this release 14.1 (autotools is still available for this release but expected to disappear with version 15.0). It would thus be desirable to support cmake from spack in the future, but for now this PR is good to get version 14.1 into spack.
tldahlgren
approved these changes
May 9, 2024
arezaii
pushed a commit
to arezaii/spack
that referenced
this pull request
May 31, 2024
* octopus: add hash for new version * octopus: add --enable-silent-deprecation flag when @14.1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octopus 14.1 was released on 2024-05-03.
This MR:
The next steps would be to try and get the cmake build system working in our recipe.