Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAX: add v0.4.28 #44112

Merged
merged 1 commit into from
May 17, 2024
Merged

JAX: add v0.4.28 #44112

merged 1 commit into from
May 17, 2024

Conversation

adamjstewart
Copy link
Member

No description provided.

Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! One thing:

The Windows build is now built with Clang instead of MSVC.

Shouldn't affect us AFAIU, right?

@adamjstewart
Copy link
Member Author

Nope, the user can choose both compilers. Not even sure if this builds on Windows yet. We'll likely add Windows CI in the future to test.

@jonas-eschle
Copy link
Contributor

jonas-eschle commented May 13, 2024

We'll likely add Windows CI in the future to test.

I imagine the use-case for building large scientific stacks on windows to be abithimal small :D

@adamjstewart
Copy link
Member Author

You'd be surprised, conda is very popular on Windows.

@jonas-eschle
Copy link
Contributor

jonas-eschle commented May 13, 2024

Yes, conda hardly surprises me (I mean, the fact that many people use windows for coding surprised me, but let's take that fact as given), but I think because that's the only way to reasonable install packages for data analysis as an end-user, spack has AFAIU a very different target audience, i.e. HPC, built by source, and usually on servers rather than desktop (or to setup a VM, which hopefully Windows isn't used a lot). But I may be wrong, curious to see if there is an estimate on the spack usage on windows.
Sorry for the digress ;)

@alalazo alalazo merged commit 8d01e8c into spack:develop May 17, 2024
14 checks passed
@adamjstewart adamjstewart deleted the packages/py-jax branch May 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants