Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmaintained pkgs: bump versions 2024-05-10 #44131

Merged
merged 13 commits into from
May 15, 2024

Conversation

alecbcs
Copy link
Member

@alecbcs alecbcs commented May 11, 2024

Add new versions to unmaintained packages.

Test Plan:
All built successfully using gcc@10.3.1 on RHEL 8.

@alecbcs
Copy link
Member Author

alecbcs commented May 11, 2024

@robertu94 It looks like dlib was misconfigured with an invalid maintainers list. I fixed it in this PR and you should now start to get messages when the package is modified.

@robertu94
Copy link
Contributor

@robertu94 It looks like dlib was misconfigured with an invalid maintainers list. I fixed it in this PR and you should now start to get messages when the package is modified.

Thanks!

@alecbcs
Copy link
Member Author

alecbcs commented May 12, 2024

@spackbot fix style

Copy link

spackbot-app bot commented May 12, 2024

Let me see if I can fix that for you!

Copy link

spackbot-app bot commented May 12, 2024

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/axel/package.py
  var/spack/repos/builtin/packages/biobambam2/package.py
  var/spack/repos/builtin/packages/chapel/package.py
  var/spack/repos/builtin/packages/cjson/package.py
  var/spack/repos/builtin/packages/clp/package.py
  var/spack/repos/builtin/packages/cmor/package.py
  var/spack/repos/builtin/packages/cppad/package.py
  var/spack/repos/builtin/packages/cryptopp/package.py
  var/spack/repos/builtin/packages/dlib/package.py
  var/spack/repos/builtin/packages/entt/package.py
  var/spack/repos/builtin/packages/flint/package.py
  var/spack/repos/builtin/packages/fpocket/package.py
  var/spack/repos/builtin/packages/hisat2/package.py
  var/spack/repos/builtin/packages/hw-probe/package.py
  var/spack/repos/builtin/packages/icu4c/package.py
  var/spack/repos/builtin/packages/imath/package.py
  var/spack/repos/builtin/packages/imgui/package.py
  var/spack/repos/builtin/packages/iniparser/package.py
  var/spack/repos/builtin/packages/libabigail/package.py
  var/spack/repos/builtin/packages/libbsd/package.py
  var/spack/repos/builtin/packages/libcap/package.py
  var/spack/repos/builtin/packages/libdmx/package.py
  var/spack/repos/builtin/packages/libedit/package.py
  var/spack/repos/builtin/packages/libfyaml/package.py
  var/spack/repos/builtin/packages/libgit2/package.py
  var/spack/repos/builtin/packages/libnids/package.py
  var/spack/repos/builtin/packages/libyogrt/package.py
  var/spack/repos/builtin/packages/lizard/package.py
  var/spack/repos/builtin/packages/lmod/package.py
  var/spack/repos/builtin/packages/lua-mpack/package.py
  var/spack/repos/builtin/packages/masurca/package.py
  var/spack/repos/builtin/packages/mercurial/package.py
  var/spack/repos/builtin/packages/metaphysicl/package.py
  var/spack/repos/builtin/packages/miniamr/package.py
  var/spack/repos/builtin/packages/mongo-cxx-driver/package.py
  var/spack/repos/builtin/packages/nghttp2/package.py
  var/spack/repos/builtin/packages/ninja/package.py
  var/spack/repos/builtin/packages/numactl/package.py
  var/spack/repos/builtin/packages/openblas/package.py
  var/spack/repos/builtin/packages/openimagedenoise/package.py
  var/spack/repos/builtin/packages/pango/package.py
  var/spack/repos/builtin/packages/perl-dbd-pg/package.py
  var/spack/repos/builtin/packages/perl-devel-stacktrace/package.py
  var/spack/repos/builtin/packages/perl-extutils-installpaths/package.py
  var/spack/repos/builtin/packages/perl-io-socket-ssl/package.py
  var/spack/repos/builtin/packages/perl-io-tty/package.py
  var/spack/repos/builtin/packages/perl-math-bigint/package.py
  var/spack/repos/builtin/packages/perl-module-build/package.py
  var/spack/repos/builtin/packages/perl-module-corelist/package.py
  var/spack/repos/builtin/packages/perl-moose/package.py
  var/spack/repos/builtin/packages/perl-path-tiny/package.py
  var/spack/repos/builtin/packages/perl-test-warnings/package.py
  var/spack/repos/builtin/packages/perl-xml-parser/package.py
  var/spack/repos/builtin/packages/pixman/package.py
  var/spack/repos/builtin/packages/planck-likelihood/package.py
  var/spack/repos/builtin/packages/postgresql/package.py
  var/spack/repos/builtin/packages/pugixml/package.py
  var/spack/repos/builtin/packages/qualimap/package.py
  var/spack/repos/builtin/packages/rsbench/package.py
  var/spack/repos/builtin/packages/samblaster/package.py
  var/spack/repos/builtin/packages/sdl2-image/package.py
  var/spack/repos/builtin/packages/setxkbmap/package.py
  var/spack/repos/builtin/packages/sheenbidi/package.py
  var/spack/repos/builtin/packages/snptest/package.py
  var/spack/repos/builtin/packages/solr/package.py
  var/spack/repos/builtin/packages/span-lite/package.py
  var/spack/repos/builtin/packages/sse2neon/package.py
  var/spack/repos/builtin/packages/star/package.py
  var/spack/repos/builtin/packages/storm/package.py
  var/spack/repos/builtin/packages/stow/package.py
  var/spack/repos/builtin/packages/taskflow/package.py
  var/spack/repos/builtin/packages/telegraf/package.py
  var/spack/repos/builtin/packages/tengine/package.py
  var/spack/repos/builtin/packages/texinfo/package.py
  var/spack/repos/builtin/packages/tig/package.py
  var/spack/repos/builtin/packages/tkrzw/package.py
  var/spack/repos/builtin/packages/tpm2-tss/package.py
  var/spack/repos/builtin/packages/trompeloeil/package.py
  var/spack/repos/builtin/packages/util-linux-uuid/package.py
  var/spack/repos/builtin/packages/valijson/package.py
  var/spack/repos/builtin/packages/wxwidgets/package.py
  var/spack/repos/builtin/packages/xbraid/package.py
  var/spack/repos/builtin/packages/xxhash/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/pixman/package.py
All done! ✨ 🍰 ✨
1 file reformatted, 82 files left unchanged.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 625 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

wdconinc
wdconinc previously approved these changes May 14, 2024
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through all of them, with more attention to more major version number changes. No remaining concerns.

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
@wdconinc wdconinc self-requested a review May 14, 2024 15:24
@alecbcs alecbcs enabled auto-merge (squash) May 14, 2024 15:42
@alecbcs
Copy link
Member Author

alecbcs commented May 14, 2024

@spackbot run pipeline

Copy link

spackbot-app bot commented May 14, 2024

I've started that pipeline for you!

@alecbcs
Copy link
Member Author

alecbcs commented May 15, 2024

@spackbot run pipeline 😭

Copy link

spackbot-app bot commented May 15, 2024

I've started that pipeline for you!

@alecbcs alecbcs merged commit d058928 into spack:develop May 15, 2024
14 checks passed
@alecbcs alecbcs deleted the unmaintained/2024-05-10 branch May 15, 2024 18:04
@alecbcs alecbcs self-assigned this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants