Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-pyqt5-sip: add 12.13.0 and fix build with gcc@14 #44133

Merged
merged 1 commit into from
May 19, 2024

Conversation

michaelkuhn
Copy link
Member

No description provided.

Copy link

spackbot-app bot commented May 11, 2024

Hi @michaelkuhn! I noticed that the following package(s) don't yet have maintainers:

  • py-pyqt5-sip

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("michaelkuhn")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-pyqt5-sip

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@alalazo
Copy link
Member

alalazo commented May 17, 2024

@michaelkuhn I assumed you tested some build, right?

@michaelkuhn
Copy link
Member Author

Yes, these are the changes I did to get our GCC 14 stack to build.

@alalazo alalazo merged commit 625f532 into spack:develop May 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants