glibc: detect from "Free Software Foundation" not "gnu" #44154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I would like to confirm that everything now works that did not work in #44145 , i.e., this fix appears to work. :-) |
zzzoom
pushed a commit
to zzzoom/spack
that referenced
this pull request
May 20, 2024
which should be more generic
gartung
added a commit
to FNALssi/spack
that referenced
this pull request
May 31, 2024
commit a5e657a Author: Harmen Stoppels <me@harmenstoppels.nl> Date: Fri May 24 13:25:59 2024 +0200 Prefer libiconv for iconv (spack#44335) `glibc` and `musl` provide a basic implementation of `iconv` (`iconv`, `iconv_open`, `iconv_close`), but in practice the installation may be missing the character encoding methods to make them usable. On Fedora for example, users need to ```yum install glibc-gconv-extra``` to get the character encodings that `gettext` requires during configure, namely EUC-JP. Users may not have permissions to install the missing parts of glibc. Since Spack can install `libiconv`, it is simpler to use that by default. commit 1da8a67 Author: Harmen Stoppels <me@harmenstoppels.nl> Date: Wed May 22 17:36:42 2024 +0200 gcc: use -rpath {rpath_dir} not -rpath={rpath dir} (spack#44315) to make macOS's linker happy. commit d957b6c Author: Mosè Giordano <giordano@users.noreply.github.com> Date: Thu May 16 10:07:18 2024 +0100 suite-sparse: improve setting of the `libs` property (spack#44214) on some distros it is in lib64/ commit 5bb34a3 Author: Massimiliano Culpo <massimiliano.culpo@gmail.com> Date: Tue May 21 14:09:29 2024 +0200 Demote a warning to debug message, if C compiler is not there (spack#44182) commit 8584ca5 Author: Massimiliano Culpo <massimiliano.culpo@gmail.com> Date: Tue May 21 08:41:09 2024 +0200 ASP-based solver: fix version optimization for roots (spack#44272) This fixes a bug occurring when two root specs need to select old versions, and these versions have the same penalty in the optimization. This sometimes caused an older version to be preferred to a more recent one. The issue was the omission of `PackageNode` in the optimization tuple. commit cfe36fc Author: Chris Green <greenc@fnal.gov> Date: Sat May 18 04:32:06 2024 -0500 git: bump v2.39 to 2.45; deprecate unsafe versions (spack#44248) commit 17668b1 Author: Scott Wittenburg <scott.wittenburg@kitware.com> Date: Sat May 18 03:57:53 2024 -0600 oci buildcache: handle pagination of tags (spack#43136) This fixes an issue where ghcr, gitlab and possibly other container registries paginate tags by default, which violates the OCI spec v1.0, but is common practice (the spec was broken itself). After this commit, you can create build cache indices of > 100 specs on ghcr. Co-authored-by: Harmen Stoppels <me@harmenstoppels.nl> commit 88b71b9 Author: Harmen Stoppels <me@harmenstoppels.nl> Date: Fri May 17 12:29:56 2024 +0200 build_environment.py: deal with rpathing identical packages (spack#44219) When multiple gcc-runtime packages exist in the same link sub-dag, only rpath the latest. commit c6ea242 Author: Howard Pritchard <hppritcha@gmail.com> Date: Thu May 16 07:18:44 2024 -0700 py-matplotlib: qualify when to do a post install (spack#44191) * py-matplotlib: qualify when to do a post install Older versions of py-matplotlib don't seem to have some of the files that the post install step is trying to install. Looks like the files first appeared in 3.6.0 and later. Signed-off-by: Howard Pritchard <hppritcha@gmail.com> * Change install paths for older matplotlib --------- Signed-off-by: Howard Pritchard <hppritcha@gmail.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> commit d840607 Author: Alec Scott <hi@alecbcs.com> Date: Tue May 14 08:14:34 2024 -0700 rust: fix v1.78.0 instructions (spack#44127) commit 1a5786f Author: Harmen Stoppels <me@harmenstoppels.nl> Date: Mon May 13 20:11:27 2024 +0200 glibc: detect from "Free Software Foundation" not "gnu" (spack#44154) which should be more generic
arezaii
pushed a commit
to arezaii/spack
that referenced
this pull request
May 31, 2024
which should be more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44145
ld.so --versionandldd --versiondo not always containgnubut seem toconsistently mention the free software foundation, so let's use that for
detection.