Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exawind: updates to package to allow mixed device #44159

Merged
merged 8 commits into from
May 14, 2024
Merged

exawind: updates to package to allow mixed device #44159

merged 8 commits into from
May 14, 2024

Conversation

jrood-nrel
Copy link
Member

No description provided.

@psakievich
Copy link
Contributor

@jrood-nrel do you intend to support exawind+nalu_wind_gpu~amr_wind_gpu? Is that ever a thing? If not then I think we could simplify this a lot with a +hybrid_device flag.

Then there are three cases

exawind+[cuda/rocm]~hybrid_device # == exawind+[cuda/rocm]+nalu_wind_gpu+amr_wind_gpu
exawind+[cuda/rocm]+hybrid_device # == exawind+[cuda/rocm]~nalu_wind_gpu+amr_wind_gpu
exawind~[cuda/rocm]~hybrid_device # == exawind~[cuda/rocm]~nalu_wind_gpu~amr_wind_gpu

@jrood-nrel
Copy link
Member Author

Yeah I think it should be open to a matrix of 4 options and not 3.

psakievich
psakievich reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@psakievich psakievich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions for a cleaner syntax when the same condition exists for conflicts

var/spack/repos/builtin/packages/exawind/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/exawind/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/exawind/package.py Outdated Show resolved Hide resolved
@psakievich psakievich merged commit a5c8111 into spack:develop May 14, 2024
14 checks passed
@jrood-nrel jrood-nrel deleted the jrood/update-exawind branch May 14, 2024 18:27
@greenc-FNAL greenc-FNAL mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psakievich psakievich psakievich approved these changes

Assignees

@psakievich psakievich

Labels
conflicts dependencies new-variant new-version update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrood-nrel @psakievich