Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lib/include paths with oneapi #44170

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix lib/include paths with oneapi #44170

merged 1 commit into from
May 17, 2024

Conversation

wspear
Copy link
Contributor

@wspear wspear commented May 13, 2024

Is there a better way to handle this? Do we need to check for lib vs lib64?

@eugeneswalker
Copy link
Contributor

@rscohn2 is this safe for oneapi generally? any thought?

@rscohn2
Copy link
Member

rscohn2 commented May 14, 2024

@rscohn2 is this safe for oneapi generally? any thought?

It looks good. I would have done it this way:

prefix = spec["mpi"].package.component_prefix if spec["mpi"].name == "intel-oneapi-mpi" else spec["mpi"].prefix
options.append(f"-mpiinc={prefix.include}")
options.append(f"-mpilib={prefix.lib}")

But what you have is fine. I checked 2021.4: and do not see a lib64 directory.

@alalazo alalazo merged commit ddfed65 into develop May 17, 2024
14 checks passed
@alalazo alalazo deleted the wspear-tau-oneapipaths branch May 17, 2024 16:55
@alalazo alalazo self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants