Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/awscli-v2: Multiple updates and new versions for dependent package #44258

Merged

Conversation

teaguesterling
Copy link
Contributor

@teaguesterling teaguesterling commented May 18, 2024

This addresses a few things that came up while adding a new version of the awscli-v2 package:

  1. Adding a new version resulted in issues with the py-ruamel-yaml-clib, which is optional in python>=3.9
  2. The post_install block failed due to (I suspect) changes to the spack API. Reordering the decorators fixed it.
  3. The py-awscrt package was a strict version requirement, which was different than the previous version.
  4. The py-awscrt package itself needed the required version. I also took the opportunity to add some new ones.
  5. Added a list_url to make future updates easier.

@teaguesterling teaguesterling changed the title Adding new versions and list_url for future releases packages/awscli-v2: Multiple updates and new versions for dependent package May 18, 2024
@alalazo alalazo self-assigned this May 20, 2024
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @climbfuji review before merging

Copy link
Contributor

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates and for volunteering as a maintainer!

@alalazo alalazo merged commit a284057 into spack:develop May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants