-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages/awscli-v2: Multiple updates and new versions for dependent package #44258
Merged
alalazo
merged 11 commits into
spack:develop
from
teaguesterling:packages/awscli-v2_update_versions
May 20, 2024
Merged
packages/awscli-v2: Multiple updates and new versions for dependent package #44258
alalazo
merged 11 commits into
spack:develop
from
teaguesterling:packages/awscli-v2_update_versions
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teaguesterling
changed the title
Adding new versions and list_url for future releases
packages/awscli-v2: Multiple updates and new versions for dependent package
May 18, 2024
climbfuji
reviewed
May 20, 2024
alalazo
requested changes
May 20, 2024
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
alalazo
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for @climbfuji review before merging
climbfuji
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates and for volunteering as a maintainer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a few things that came up while adding a new version of the
awscli-v2
package:py-ruamel-yaml-clib
, which is optional in python>=3.9post_install
block failed due to (I suspect) changes to the spack API. Reordering the decorators fixed it.py-awscrt
package was a strict version requirement, which was different than the previous version.py-awscrt
package itself needed the required version. I also took the opportunity to add some new ones.list_url
to make future updates easier.