Enforce consistency of gl providers
#44307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the package and ensures a single gl implementation is pulled in. Before we were adding direct dependencies, and those are not unified through the virtual.
This simplifies the package and ensures a single gl implementation is pulled in. Before we were adding direct dependencies, and those are not unified through the virtual.
This simplifies the package and ensures a single gl implementation is pulled in. Before we were adding direct dependencies, and those are not unified through the virtual.
Instead, enforce consistency using the "gl" virtual that allows only one provider.
spackbot-app
bot
added
conflicts
core
|
Hi @alalazo! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("alalazo")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame mesa-demosThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
spackbot-app
bot
requested review from
cyrush,
danlipsa,
v-dobrev and
vicentebolea
|
@bollig I commented out the two |
|
Fine with me.
…-Evan Bollig
***@***.***
***@***.***
On Tue, May 21, 2024 at 4:57 PM Massimiliano Culpo ***@***.***> wrote:
@bollig <https://github.com/bollig> I commented out the two paraview
builds in the aws-isc stacks, as I think they are already covered by e4s.
Let me know if it is fine with you, or if you'd like to have them back.
—
Reply to this email directly, view it on GitHub
<#44307 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNWQTK2BPOE42NPNL22GDZDO7LRAVCNFSM6AAAAABICNYMOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGUYDKMZQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
var/spack/repos/builtin/packages/trilinos-catalyst-ioss-adapter/package.py
Show resolved
Hide resolved
kwryankrattiger
approved these changes
May 23, 2024
biddisco
approved these changes
May 23, 2024
biddisco
reviewed
May 23, 2024
There was a problem hiding this comment.
Question - if the variant GL has been removed from places, and instead the virtual provider is used as the flag, one can no longer say
spec paraview +egl
but one must instead encourage spack to use egl as the provider. What is the canonical syntax for that =- something like ???
spack spec paraview ^[virtuals=gl] egl
|
@biddisco From the command line, what you wrote is correct: $ spack spec paraview ^[virtuals=gl] eglOtherwise you can configure the provider from YAML files: packages:
gl:
require:
- egl |
alalazo
added a commit
that referenced
this pull request
Jun 5, 2024
* glew: rework dependency on gl
This simplifies the package and ensures a single gl implementation is
pulled in. Before we were adding direct dependencies, and those are
not unified through the virtual.
* mesa-demos: rework dependency on gl
This simplifies the package and ensures a single gl implementation is
pulled in. Before we were adding direct dependencies, and those are
not unified through the virtual.
* mesa-glu: rework dependency on gl
This simplifies the package and ensures a single gl implementation is
pulled in. Before we were adding direct dependencies, and those are
not unified through the virtual.
* paraview: fix dependency on glew
* mesa: group dependency on when("+glx")
* Add missing dependency on libxml2
* paraview: remove the "osmesa" and "egl" variant
Instead, enforce consistency using the "gl" virtual that allows
only one provider.
* visit: remove osmesa variant
* Disable paraview in the aws-isc stacks
* data-vis-sdk: rework constrains to enforce front-ends
* e4s-power: remove redundant paraview
* Pipelines: update osmesa variants
* trilinos-catalyst-ioss-adapter: make gl a run dependency
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
* glew: rework dependency on gl
This simplifies the package and ensures a single gl implementation is
pulled in. Before we were adding direct dependencies, and those are
not unified through the virtual.
* mesa-demos: rework dependency on gl
This simplifies the package and ensures a single gl implementation is
pulled in. Before we were adding direct dependencies, and those are
not unified through the virtual.
* mesa-glu: rework dependency on gl
This simplifies the package and ensures a single gl implementation is
pulled in. Before we were adding direct dependencies, and those are
not unified through the virtual.
* paraview: fix dependency on glew
* mesa: group dependency on when("+glx")
* Add missing dependency on libxml2
* paraview: remove the "osmesa" and "egl" variant
Instead, enforce consistency using the "gl" virtual that allows
only one provider.
* visit: remove osmesa variant
* Disable paraview in the aws-isc stacks
* data-vis-sdk: rework constrains to enforce front-ends
* e4s-power: remove redundant paraview
* Pipelines: update osmesa variants
* trilinos-catalyst-ioss-adapter: make gl a run dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44184
Many recipes in
developuse a wrong idiom of declaring a direct dependency on a provider. This might bring into the DAG two potential providers, when the one declared as a direct dependency is not the preferred one.This PR reworks a few directives to avoid that problem, and simplifies the recipes in the process. Pipelines have been updated accordingly.