Better shell completion support for packages #44756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecbcs
changed the title
alecbcs
changed the title
alecbcs
force-pushed
the
fix/better-shell-completions
branch
from
6073ec8
to
2e8ee11
Compare
alecbcs
force-pushed
the
fix/better-shell-completions
branch
from
2e8ee11
to
caecde2
Compare
alalazo
reviewed
Jun 25, 2024
Comment on lines
+1421
to
+1431
| @property | ||
| def bash_completion_path(self): | ||
| return f"{self.prefix}/share/bash-completion/completions" | ||
|
|
||
| @property | ||
| def zsh_completion_path(self): | ||
| return f"{self.prefix}/share/zsh/site-functions" | ||
|
|
||
| @property | ||
| def fish_completion_path(self): | ||
| return f"{self.prefix}/share/fish/vendor_completions.d" |
There was a problem hiding this comment.
Wondering if these attributes are best kept in a mixin, rather than extending the PackageBase class. That class is a bit overloaded with responsibilities atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a standardized way to add shell completion support to packages using
ripgrep,fd,restic, andrcloneas examples.