Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intel-oneapi 2024.2.0: added new version to packages #44789

Merged
merged 4 commits into from
Jun 21, 2024
Merged

intel-oneapi 2024.2.0: added new version to packages #44789

merged 4 commits into from
Jun 21, 2024

Conversation

prstrnn
Copy link
Contributor

@prstrnn prstrnn commented Jun 20, 2024

No description provided.

@spackbot-app spackbot-app bot requested a review from rscohn2 June 20, 2024 16:58
rscohn2
rscohn2 previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@rscohn2 rscohn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rscohn2 rscohn2 enabled auto-merge (squash) June 20, 2024 19:50
@rscohn2
Copy link
Member

rscohn2 commented Jun 20, 2024

@eugeneswalker :
I don't think gitlab-ci will pass until e4s moves forward to 2024.2 compilers

@rscohn2
Copy link
Member

rscohn2 commented Jun 21, 2024

@spackbot run pipeline

@spackbot-app spackbot-app
Copy link

spackbot-app bot commented Jun 21, 2024

I've started that pipeline for you!

@rscohn2
Copy link
Member

rscohn2 commented Jun 21, 2024

I don't think gitlab-ci will pass until e4s moves forward to 2024.2 compilers

After looking some more, it should be ok. MKL 2024.0 has preferred=true so e4s will test that version, not 2024.2.0. We still need to update the compiler in e4s so we can remove the preferred=true and test latest MKL.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality gitlab Issues related to gitlab integration labels Jun 21, 2024
@eugeneswalker
Copy link
Contributor

I don't think gitlab-ci will pass until e4s moves forward to 2024.2 compilers

We still need to update the compiler in e4s so we can remove the preferred=true and test latest MKL.

Just pushed commit here to upgrade to new 2024.2 CI image. Let's see how it goes.

@prstrnn prstrnn requested a review from rscohn2 June 21, 2024 15:54
rscohn2
rscohn2 previously approved these changes Jun 21, 2024
View reviewed changes
@rscohn2
Copy link
Member

rscohn2 commented Jun 21, 2024

gitlab passed with the old 2024.0 docker image and mkl 2024.0. Now we are using 2024.2 docker and mkl. If it does not work, I will back out so we can merge the 2024.2 release.

@rscohn2
Copy link
Member

rscohn2 commented Jun 21, 2024

@rscohn2
Copy link
Member

rscohn2 commented Jun 21, 2024

I filed internal tickets for lbann and plasma, and disabled them in e4s

eugeneswalker
eugeneswalker approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@eugeneswalker eugeneswalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rscohn2 rscohn2 merged commit 55fe735 into spack:develop Jun 21, 2024
33 of 34 checks passed
@eugeneswalker eugeneswalker mentioned this pull request Jun 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rscohn2 rscohn2 rscohn2 approved these changes

@eugeneswalker eugeneswalker eugeneswalker approved these changes

Assignees

@rscohn2 rscohn2

Labels
core PR affects Spack core functionality gitlab Issues related to gitlab integration intel new-version update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prstrnn @rscohn2 @eugeneswalker