Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legion: add redop_half variant, and add missing build dependency #44792

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Legion: add redop_half variant, and add missing build dependency #44792

merged 3 commits into from
Jun 25, 2024

Conversation

mpokorny
Copy link
Contributor

  • redop_half variant to enable half-precision reduction operators
  • add py-setuptools to build dependencies when +python is in effect

@spackbot-app spackbot-app
Copy link

spackbot-app bot commented Jun 20, 2024

@streichler can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • legion

elliottslaughter
elliottslaughter approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@elliottslaughter elliottslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor suggestion for cleanup.

var/spack/repos/builtin/packages/legion/package.py Outdated Show resolved Hide resolved
elliottslaughter
elliottslaughter approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@elliottslaughter elliottslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @tldahlgren can we merge?

@tldahlgren tldahlgren enabled auto-merge (squash) June 20, 2024 23:15
@tldahlgren tldahlgren self-assigned this Jun 20, 2024
@tldahlgren tldahlgren merged commit 99e3fdb into spack:develop Jun 25, 2024
13 checks passed
@mpokorny mpokorny deleted the legion branch June 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottslaughter elliottslaughter elliottslaughter approved these changes

@tldahlgren tldahlgren tldahlgren approved these changes

@pmccormick pmccormick Awaiting requested review from pmccormick

Assignees

@tldahlgren tldahlgren

Labels
dependencies new-variant update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpokorny @elliottslaughter @tldahlgren