cleaveland4: new package #4823
cleaveland4: new package #4823
Conversation
|
|
||
| variant('sse', default=True, description='Enable SSE in order to substantially speed up execution') | ||
| variant('perl', default=True, description='Build ViennaRNA without Perl interface') | ||
| variant('python', default=True, description='Build ViennaRNA without Python interface') |
There was a problem hiding this comment.
This is confusing if +python means without Python and -python means with python. Can you invert the logic?
|
|
||
| def url_for_version(self, version): | ||
| url = "https://www.tbi.univie.ac.at/RNA/download/sourcecode/{0}_x/ViennaRNA-{1}.tar.gz" | ||
| return url.format(version.up_to(2), version) |
There was a problem hiding this comment.
I think you need to convert the first case to underscored.
There was a problem hiding this comment.
I'm having trouble figuring out how to do this, and I could be doing it completely wrong...
def url_for_version(self, version):
url = 'https://www.tbi.univie.ac.at/RNA/download/sourcecode/{0}/ViennaRNA-2.3.5.tar.gz'
url = url.format(version.underscored)
url = 'https://www.tbi.univie.ac.at/RNA/download/sourcecode/{0}_x/ViennaRNA-{1}.tar.gz'
return url.format(version.up_to(2), version)
This returns https://www.tbi.univie.ac.at/RNA/download/sourcecode/2.3_x/ViennaRNA-2.3.5.tar.gz.
There was a problem hiding this comment.
Hmm, I can think of a hacky way to do it (use version.up_to(2) and convert dots to underscores) but I think there's a better way. Let me see if I can get up_to() to return a Version() object instead of a string so you can use version.up_to(2).underscored.
There was a problem hiding this comment.
Okay, see #4834. Once that is merged, you should be able to use the function in the PR example.
| depends_on('perl-math-cdf', type=('build', 'run')) | ||
| depends_on('bowtie') | ||
| depends_on('viennarna') | ||
| depends_on('r', type=('build', 'run')) |
There was a problem hiding this comment.
This package only installs Perl files but uses R at run-time?
There was a problem hiding this comment.
R is listed as a dependency that needs to be available as a PATH executable. In this case would it be better with the default type=('build', 'link')?
There was a problem hiding this comment.
No, if it needs to be in your PATH then you have it correct already. Is it a Perl script that calls R? Or are there other things you should be installing?
There was a problem hiding this comment.
It looks like if you provide the option -o when executing the CleaveLand.pl script, R is called from the script
adding new pacakges cleaveland, viennarna, and perl-math-cdf