buildcache install should fail if the tarball was created with a different directory layout #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/spack/spack/relocate.py
Conflicts: lib/spack/spack/relocate.py
The previous test skipped dynamically linked in filetype and never tested for ELF. Add test for relocate_text to make sure problems are found in testing. Do not include the prefix directory name in tarball. This causes problem when installing tarballs to a spack directory with a diffrent directory layout.
…ferent directory layout.
…uildcache-update-3
…uildcache-update-3
…uildcache-update-3
…le might end up in the text to relocate list is filter_file() is called during install
…uildcache-update-3
The previous test skipped dynamically linked in filetype and never tested for ELF. Add test for relocate_text to make sure problems are found in testing. Do not include the prefix directory name in tarball. This will aid later when installing to a different directory layout.
…tain compatability.
|
I assume I should look at this vs. #6512 I'll say I think more-significant changes are needed than 54340e2 as I mentioned in #6344 (review). I think it would be fastest to remove those particular changes for the time being and keep it to a separate PR. |
|
You should review and hopefully merge #6512 first. That has fixes for reported bugs. So far I am the only person who found this bug. |
…generated by filter_file()
|
resubmitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that tarballs created with a non-default directory layout cannot be relocated to a default directory layout. In this case replacing the old layout root with the new layout root does not work. The rpaths with still refer to the non-default relative prefixes.
Any replacement or rpaths happens in a workdir before moving the files to the install prefix. This prevents having a broken install prefix left over since I did not clean up on exceptions.
This PR includes
#6512
and
#6344