Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore log files that appear in root dir with "spack -d install ..." #6670

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

scottwittenburg
Copy link
Contributor

I noticed recently that when I install packages with the -d option, I have started getting a bunch of log files in the root directory of the repository:

$ git status
On branch develop
Your branch is up-to-date with 'origin/develop'.
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	spack-cc-binutils-4an3yhe.in.log
	spack-cc-binutils-4an3yhe.out.log
        ...

This PR make sure that git ignores those to avoid cluttering up status output.

@davydden
Copy link
Member

I don't know the internals of install, but most likely there is a bug somewhere that ought to be fixed so that those files do not appear in the first place.

@alalazo
Copy link
Member

alalazo commented Dec 13, 2017

@davydden Those files are, as far as I remember, written by the compiler wrappers. I think the rationale is that injected flags - like RPATHs and such - don't appear in the logs, as they are internal to the wrapper. When you activate debugging the compiler wrapper writes in a file, like spack-cc-binutils-4an3yhe.in.log, what it received in input and in another what it actually executed.

@davydden
Copy link
Member

i see, thanks for explanation

@alalazo
Copy link
Member

alalazo commented Dec 13, 2017

@tgamblin @scheibelp I am going to merge this

@alalazo alalazo merged commit 6628b6c into spack:develop Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants