Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages can tune the list of files to be archived at the end of install #7760

Merged
merged 5 commits into from
May 9, 2018
Merged

Packages can tune the list of files to be archived at the end of install #7760

merged 5 commits into from
May 9, 2018

Commits on May 5, 2018

  1. Packages can tune the list of files to be archived at the end of install 

    fixes spack#2781

This PR introduces a new attribute for packages that contains a list
of glob expressions. Any file that matches will be archived in the
`<prefix>/.spack/archived-files` directory.

`AutotoolsPackage` and `CMakePackage` provide a sensible default
override for this attribute.
    @alalazo
    alalazo committed May 5, 2018
    Configuration menu
    Copy the full SHA
    a7ffaf0 View commit details
    Browse the repository at this point in the history

  2. Archive files default take into account the build directory 

    The glob expressions that can be used in the `archive_files` list now
are also allowed to be absolute. The errors that may occur when
archiving custom files are collected and reported in a file named
`errors.txt`.
    @alalazo
    alalazo committed May 5, 2018
    Configuration menu
    Copy the full SHA
    07c8350 View commit details
    Browse the repository at this point in the history

  3. Added a unit test to ensure that extra files are archived properly

    @alalazo
    alalazo committed May 5, 2018
    Configuration menu
    Copy the full SHA
    d084326 View commit details
    Browse the repository at this point in the history

  4. Modified unit test to hit exceptional paths 

    This ensures that errors when archiving files are recorded into
.spack/archived-files/errors.txt
    @alalazo
    alalazo committed May 5, 2018
    Configuration menu
    Copy the full SHA
    f6bebeb View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. Moved logic to test archiving files into its own mock package

    @alalazo
    alalazo committed May 8, 2018
    Configuration menu
    Copy the full SHA
    d02f9fb View commit details
    Browse the repository at this point in the history