Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module_cmd finding for zsh #7884

Closed
wants to merge 3 commits into from
Closed

Conversation

EmreAtes
Copy link
Contributor

I'm running spack on a system with zsh and the module function is as follows:

$ typeset -f module | envsubst
module () {
	eval `/usr/local/Modules/3.2.10/bin/modulecmd zsh $*`
}

The current regex cannot process this.

@EmreAtes
Copy link
Contributor Author

I added the universal_newlines parameter in the last commit, because without the parameter popen returns a byte-string, and re doesn't work with byte strings if the search string is not a byte string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants