Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version detection for gcc@8 #8511

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Fix version detection for gcc@8 #8511

merged 1 commit into from
Jun 22, 2018

Conversation

michaelkuhn
Copy link
Member

This is a quick patch to fix gcc@8. Maybe we should come up with something more future-proof. :-)

@adamjstewart
Copy link
Member

adamjstewart commented Jun 19, 2018 •
edited

Maybe we should come up with something more future-proof.

You could do:

if ver(version) >= ver('7'):

@michaelkuhn
Copy link
Member Author

You could do:
if ver(version) >= ver('7'):

That seems to work. Thanks!

@adamjstewart adamjstewart merged commit c2d56b0 into spack:develop Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalazo alalazo alalazo approved these changes

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
compilers gcc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelkuhn @adamjstewart @alalazo