Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hwloc and numactl updates #9987

Merged
merged 6 commits into from Dec 5, 2018
Merged

Hwloc and numactl updates #9987

merged 6 commits into from Dec 5, 2018

Conversation

jrood-nrel
Copy link
Member

Just adding some new versions, although OpenMPI will choose these new versions. I think @alalazo tends to handle OpenMPI related stuff.

@jrood-nrel
Copy link
Member Author

@ax3l This look a little better?

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@ax3l
Copy link
Member

ax3l commented Dec 3, 2018

@jrood-nrel ah, but now you added gl as well, which you should then depends_on('gl', when='+gl')

@ax3l
Copy link
Member

ax3l commented Dec 3, 2018

@jrood-nrel does this line depends_on('numactl', when='@:1.11.9 platform=linux') still apply? If so, please bump the range accordingly.

@jrood-nrel
Copy link
Member Author

So I'm not so sure about whether it's good to list opengl as a dependency when +gl, but I needed hwloc~gl for my current system anyway which is why I added it, so that's fine with me.

@ax3l
Copy link
Member

ax3l commented Dec 4, 2018

@jrood-nrel thank you for all the updates! :)

@ax3l ax3l merged commit 583617e into spack:develop Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants